Skip to content

Don't url encode provider config #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2017
Merged

Don't url encode provider config #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions ios/OAuthManager/OAuthManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,14 +149,11 @@ - (BOOL) _configureProvider:(NSString *)providerName andConfig:(NSDictionary *)c
if ([name rangeOfString:@"_url"].location != NSNotFound) {
// This is a URL representation
NSString *urlStr = [config valueForKey:name];
NSURL *url = [NSURL URLWithString:[urlStr
stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]];
NSURL *url = [NSURL URLWithString:urlStr];
[objectProps setObject:url forKey:name];
} else {
NSString *str = [NSString stringWithString:[config valueForKey:name]];
NSString *escapedStr = [str
stringByAddingPercentEncodingWithAllowedCharacters:[NSCharacterSet URLHostAllowedCharacterSet]];
[objectProps setValue:[escapedStr copy] forKey:name];
[objectProps setValue:str forKey:name];
}
}

Expand Down