Update external testing CI with libbet's new way of running Python - #2039
Merged
Conversation
Rangi42
added
tests
Rangi42
marked this pull request as draft
July 31, 2026 02:39
Rangi42
force-pushed
the
libbet-cygwin
branch
2 times, most recently
from
July 31, 2026 19:39
1c0cd2b to
c31fc5a
Compare
libbet now uses `py -3` if the `py` binary exists, instead of if `COMSPEC` is defined. So we don't need to `unset COMSPEC`, we just need to avoid Windows' `py` launcher from being in Cygwin's `PATH`. It turns out that `C:\cygwin\bin\env.exe CYGWIN_NOWINPATH=1 ...` was not effectively preventing Windows' `PATH` from being inherited by Cygwin's `PATH`, because to take effect it needs to run Cygwin's `/etc/profile` script. The simple way to do that is using a login shell. So we don't need the `PREFIX`/`--prefix` from the previous commit after all.
Rangi42
marked this pull request as ready for review
July 31, 2026 19:43
Rangi42
changed the title
ISSOtm
approved these changes
Aug 1, 2026
ISSOtm
left a comment
ISSOtm
left a comment
Member
There was a problem hiding this comment.
Nice! This also feels a bit cleaner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After pinobatch/libbet#22, libbet now uses
py -3if thepybinary exists, instead of ifCOMSPECis defined. So we don't need tounset COMSPEC, we just need to avoid Windows'pylauncher from being in Cygwin'sPATH.It turns out that
C:\cygwin\bin\env.exe CYGWIN_NOWINPATH=1 ...was not effectively preventing Windows'PATHfrom being inherited by Cygwin'sPATH, because to take effect it needs to run Cygwin's/etc/profilescript. The simple way to do that is using a login shell. So we don't need thePREFIX/--prefixfrom the previous commit after all.With this PR, we're now correctly following the advice from https://github.com/cygwin/cygwin-install-action#a-clean-path: