-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
docs(session-replay): Clarify iOS performance impact on older devices #16205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Overhaul the Session Replay performance overhead documentation to better communicate the potential for scrolling stutter and frame drops on older iOS devices. This addresses feedback that the documentation didn't clearly explain the impact on scroll behavior. Changes: - Add dedicated "Performance on Older Devices" section with clear warning - Explain why stutter occurs (main thread blocking during screenshot capture) - Document scenarios that increase likelihood of stutter (heavy animations, complex view hierarchies) - Add "Understanding Main Thread Impact" section with timing details - Include View Renderer V2 performance comparison table - Add cross-references from React Native and mobile docs to iOS-specific guidance Closes getsentry/sentry-cocoa#7225
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
|
||
| ```swift | ||
| SentrySDK.start(configureOptions: { options in | ||
| options.sessionReplay.enableFastViewRendering = true | ||
| }) | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The documentation for sessionReplay.enableFastViewRendering omits the requirement that enableViewRendererV2 must also be enabled, unlike the corresponding screenshot documentation.
Severity: MEDIUM
Suggested Fix
Update the "Enable Fast View Rendering" section in the Session Replay documentation to include a note, similar to the one for screenshots, stating that enableFastViewRendering requires enableViewRendererV2 to be enabled to function correctly.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: docs/platforms/apple/common/session-replay/performance-overhead.mdx#L130-L135
Potential issue: The new documentation for `sessionReplay.enableFastViewRendering` fails
to mention its dependency on `enableViewRendererV2`. The documentation for the
equivalent screenshot feature explicitly states this requirement. A user could disable
`enableViewRendererV2` for troubleshooting and then enable `enableFastViewRendering`,
expecting a performance gain that will not materialize because the prerequisite is
missing. This inconsistency can lead to incorrect SDK configuration and the feature not
providing the expected performance benefits.
Did we get this right? 👍 / 👎 to inform future reviews.
antonis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for also updating the RN section 🙇
DESCRIBE YOUR PR
Overhaul the Session Replay performance overhead documentation to better communicate the potential for scrolling stutter and frame drops on older iOS devices. This addresses feedback that the documentation didn't clearly explain the impact on scroll behavior.
Changes:
Closes getsentry/sentry-cocoa#7225
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: