Skip to content

Conversation

@lcian
Copy link
Member

@lcian lcian commented Aug 8, 2025

📜 Description

Update trace origins to use the new module names instead of the old ones.
Occurences were found and replaced with:

rg --pcre2 'jakarta(?!\.servlet)' -g '*.kt' -g '*.java' -l | xargs sed -i '' 's/spring_jakarta/spring7/g'

💡 Motivation and Context

Correct trace origins.

💚 How did you test it?

Updated occurences in tests too.

@lcian lcian changed the title Add new modules for Spring 7 and Spring Boot 4 Aug 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Update trace origins for Spring 7 and Spring Boot 4 ([#4620](https://github.com/getsentry/sentry-java/pull/4620))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 6fe7509

Base automatically changed from 08-07-fix_class_not_found_due_to_otel_not_supporting_spring_boot_4_yet to 08-07-move_spring_7_and_spring_boot_4_packages August 8, 2025 10:01
Base automatically changed from 08-07-move_spring_7_and_spring_boot_4_packages to 08-07-fix_tests_for_spring_7_and_spring_boot_4 August 8, 2025 10:01
@lcian lcian changed the base branch from 08-07-fix_tests_for_spring_7_and_spring_boot_4 to 08-04-add_new_modules_for_spring_7_and_spring_boot_4 August 8, 2025 11:28
@lcian lcian marked this pull request as draft August 8, 2025 11:29
@adinauer
Copy link
Member

Thanks for the PR, since this has so many merge conflicts after messing with the PRs it's based on, I'll just apply the changes on #4614 directly.

@adinauer adinauer closed this Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants