Skip to content

ref(forms): Convert ChoiceMapperField and TableField to functional components #106494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
ryan953 wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

ref(forms): Convert ChoiceMapperField and TableField to functional components #106494

ryan953 wants to merge 3 commits into from

Conversation

@ryan953
Copy link
Member

@ryan953 ryan953 commented Jan 17, 2026

Summary

Refactors ChoiceMapperField and TableField from class components to functional components to align with modern React patterns and Sentry's frontend guidelines (no new class components).

These components were identified as stateless class components (no internal state management), making them ideal candidates for conversion to functional components.

Changes

ChoiceMapperField

  • Converted class component to functional component
  • Removed Component import and class syntax
  • Moved static defaultProps to default parameter values
  • Moved hasValue instance method to standalone helper function
  • Maintained all existing functionality including async dropdown support

TableField

  • Converted class component to functional component
  • Removed Component import and class syntax
  • Moved static defaultProps to default parameter values
  • Moved hasValue instance method to standalone helper function
  • Maintained all existing functionality including row add/remove operations

Test plan

  • ✅ Linting passes for both components
  • ✅ All existing tests pass:
    • choiceMapperField.spec.tsx - 9 tests passing
    • tableField.spec.tsx - 6 tests passing
  • ✅ No functional changes - component behavior is identical
@ryan953
ref(forms): Convert ChoiceMapperField and TableField to functional co…
cb1fae8 
…mponents

Refactors ChoiceMapperField and TableField from class components to functional components to align with modern React patterns and Sentry's frontend guidelines (no new class components).

Changes:
- Converted both class components to functional components
- Removed Component import and class syntax
- Moved static defaultProps to default parameter values
- Moved instance methods to standalone helper functions
- Maintained all existing functionality and behavior

These were identified as stateless class components (no internal state management), making them ideal candidates for conversion to functional components.
@ryan953 ryan953 requested a review from a team as a code owner January 17, 2026 04:20
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 17, 2026
@ryan953 ryan953 marked this pull request as draft January 17, 2026 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

2 participants

@ryan953