Skip to content

Conversation

@ryan953 ryan953 requested review from a team as code owners January 23, 2026 18:42
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 23, 2026
The getAttachmentUrl refactor changed how download parameters are handled:
- OLD: URL hardcoded ?download in the string
- NEW: URL is clean, download added via query: {download: true}

When useApiQuery processes {query: {download: true}}, it serializes to
?download=true, not ?download. Tests need to use matchQuery to properly
match query parameters.
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

owner: integratedOrgId!,
},
}
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mismatched query key format breaks cache invalidation

Medium Severity

The query key in useInfiniteRepositories.tsx now uses getApiUrl() which URL-encodes path parameters, but the corresponding invalidateQueries call in useSyncRepos.tsx still uses string interpolation without encoding. If organization.slug or integratedOrgId contain special characters (spaces, slashes, etc.), the query key and invalidation key won't match, causing the cache invalidation to silently fail after repository sync completes.

Additional Locations (1)

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

3 participants