Skip to content

fix(cache) Options should use the defined cache when available v2 #106938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
markstory wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix(cache) Options should use the defined cache when available v2 #106938

markstory wants to merge 6 commits into from
+49 −3

Conversation

@markstory
Copy link
Member

@markstory markstory commented Jan 24, 2026

The changes from #106115 were reverted because of issues in our production environment. These changes don't use caches['default'] and instead continue using the default_cache ConnectionProxy unless the options backend is configured in settings.
@markstory
Reapply "feat(options) Use a dedicated cache profile for options (#10…
fdeca81 
…6115)"

This reverts commit 8a9861a.
@markstory
Check settings instead of cache registry, and use default_cache
6e2b5d2 
Indexing into `caches` caused cache connection rates to drop in
single-tenants. This change preserves the original behavior better
than my last attempt did.
@markstory markstory requested a review from a team January 24, 2026 19:01
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 24, 2026
@markstory markstory marked this pull request as draft January 24, 2026 20:44
@markstory
Use ConnectionProxy instead
eabbfd2 
The default_cache object is a proxy that wraps
Django's caches, which stores instances in
a thread local.
@markstory markstory marked this pull request as ready for review January 26, 2026 14:45
evanh
evanh approved these changes Jan 26, 2026
View reviewed changes
src/sentry/runner/initializer.py
# Prefer the 'options' cache profile if defined.
# Use a ConnectionProxy as caches['options'] performs
# poorly in threaded contexts.
# We type ignore because django's types are lies and default_cache
Copy link
Member

@evanh evanh Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

django's types are lies

😆
wedamija
wedamija approved these changes Jan 26, 2026
View reviewed changes
Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's only deploy this early in the day so we have time to monitor. I didn't realise that this was the root cause of an incident I had on Friday
@markstory
Copy link
Member Author

markstory commented Jan 26, 2026

Let's only deploy this early in the day so we have time to monitor. I didn't realise that this was the root cause of an incident I had on Friday

👍 that was my plan.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

4 participants

@markstory @evanh @wedamija