-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat(notifications): Add Size Analysis to notification settings UI #106940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
cb142ff to
3d8a691
Compare
static/app/views/settings/account/notifications/notificationSettingsByType.tsx
Outdated
Show resolved
Hide resolved
332f050 to
a5c10b0
Compare
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
- Set isBilledCategory: true for SIZE_ANALYSIS in DATA_CATEGORY_INFO - Add expose-category-size-analysis feature flag filtering in filterCategoryFields() - Gate quotaSizeAnalyses notification setting behind feature flag Closes BIL-2007
…tions Add the missing reservedSizeAnalyses property to all Reservations objects to fix TypeScript compilation errors in CI. This property was added to the Reservations type but was missing in several test files and implementation. Fixes: - productSelectionAvailability.spec.tsx - productUnavailableCTA.spec.tsx - usePreviewData.spec.tsx - useUpgradeNowParams.tsx
…ctations Update test expectations to include the reservedSizeAnalyses property that was added to the Reservations type in the implementation.
…frontend The backend notification setting used singular form `quotaSizeAnalysis` but the frontend DataCategory convention generates plural form `quotaSizeAnalyses`. This mismatch caused the Size Analysis notification setting to be non-functional. Changed backend from `quotaSizeAnalysis` to `quotaSizeAnalyses` to match the frontend convention and be consistent with similar settings like `quotaSeerUsers`.
…xture The am2Plans fixture returns sizeAnalyses with events: 100, so the test expectations should be 100, not undefined.
… RPC API The change from `quotaSizeAnalysis` to `quotaSizeAnalyses` was flagged as a breaking change by the openapi-diff CI check since the production RPC schema already contains the original value. Reverted to maintain backwards compatibility.
25fe0ab to
bfd96a1
Compare
closes https://linear.app/getsentry/issue/BIL-2007/add-size-analysis-to-notification-settings-ui-frontend
Summary
Enable the Size Analysis quota notification setting to appear in the user notification settings UI, gated behind the
expose-category-size-analysisfeature flag.isBilledCategory: truefor SIZE_ANALYSIS inDATA_CATEGORY_INFOexpose-category-size-analysisfeature flag filtering infilterCategoryFields()quotaSizeAnalysesnotification setting behind feature flagDependencies
Test plan