Skip to content

Conversation

@dashed
Copy link
Member

@dashed dashed commented Jan 25, 2026

closes https://linear.app/getsentry/issue/BIL-2007/add-size-analysis-to-notification-settings-ui-frontend

Summary

Enable the Size Analysis quota notification setting to appear in the user notification settings UI, gated behind the expose-category-size-analysis feature flag.

  • Set isBilledCategory: true for SIZE_ANALYSIS in DATA_CATEGORY_INFO
  • Add expose-category-size-analysis feature flag filtering in filterCategoryFields()
  • Gate quotaSizeAnalyses notification setting behind feature flag

Dependencies

  • Requires PR #106939 (BIL-1918) to be merged first

Test plan

  • Existing notification settings tests pass (18 tests)
  • Pre-commit checks pass
  • Manual verification that Size Analysis appears in notification settings only when feature flag is enabled
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 25, 2026
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 26, 2026
@dashed dashed removed the Scope: Backend Automatically applied to PRs that change backend components label Jan 26, 2026
@getsentry getsentry deleted a comment from github-actions bot Jan 26, 2026
@dashed dashed self-assigned this Jan 26, 2026
@dashed dashed marked this pull request as ready for review January 26, 2026 22:14
@dashed dashed requested a review from a team as a code owner January 26, 2026 22:14
@dashed dashed requested a review from a team January 26, 2026 22:14
@dashed dashed requested a review from a team as a code owner January 27, 2026 21:37
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 27, 2026
@github-actions
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

- Set isBilledCategory: true for SIZE_ANALYSIS in DATA_CATEGORY_INFO
- Add expose-category-size-analysis feature flag filtering in filterCategoryFields()
- Gate quotaSizeAnalyses notification setting behind feature flag

Closes BIL-2007
…tions

Add the missing reservedSizeAnalyses property to all Reservations objects
to fix TypeScript compilation errors in CI. This property was added to the
Reservations type but was missing in several test files and implementation.

Fixes:
- productSelectionAvailability.spec.tsx
- productUnavailableCTA.spec.tsx
- usePreviewData.spec.tsx
- useUpgradeNowParams.tsx
…ctations

Update test expectations to include the reservedSizeAnalyses property
that was added to the Reservations type in the implementation.
…frontend

The backend notification setting used singular form `quotaSizeAnalysis`
but the frontend DataCategory convention generates plural form
`quotaSizeAnalyses`. This mismatch caused the Size Analysis notification
setting to be non-functional.

Changed backend from `quotaSizeAnalysis` to `quotaSizeAnalyses` to match
the frontend convention and be consistent with similar settings like
`quotaSeerUsers`.
…xture

The am2Plans fixture returns sizeAnalyses with events: 100, so the test
expectations should be 100, not undefined.
… RPC API

The change from `quotaSizeAnalysis` to `quotaSizeAnalyses` was flagged
as a breaking change by the openapi-diff CI check since the production
RPC schema already contains the original value. Reverted to maintain
backwards compatibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

3 participants