-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
ref(button) move title to tooltipProps #106987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JonasBa
wants to merge
10
commits into
master
Choose a base branch
from
jb/button/cleanup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+684
−585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
09b452a to
2f5e86e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The decision to merge tooltip and button props has not stood the test of time well, and will be something that we will remove.
The main reason for this change is that the abstraction to wrap
Buttonwith<Tooltip><Button>is a) very cheap and b) explicit and what you would expect.Wee are seeing that even though Buttons natively support tooltips, developers will still reach for the
Tooltipcomponent, resulting in expanded JSX that which looks like<Tooltip><Tooltip><button>...</button></Tooltip></Tooltip>where only the external tooltip is rendered and the internal one is wasted.Wrapping a Tooltip around our Button in all instances also adds runtime cost that could otherwise be avoided entirely, and results in a smaller prop definition that only relates to the button. Developers get a more explicit API with better LSP experience while also giving us the bonus of a faster runtime experience.