Skip to content

Conversation

@JonasBa
Copy link
Member

@JonasBa JonasBa commented Jan 26, 2026

The decision to merge tooltip and button props has not stood the test of time well, and will be something that we will remove.

The main reason for this change is that the abstraction to wrap Button with <Tooltip><Button> is a) very cheap and b) explicit and what you would expect.

Wee are seeing that even though Buttons natively support tooltips, developers will still reach for the Tooltip component, resulting in expanded JSX that which looks like <Tooltip><Tooltip><button>...</button></Tooltip></Tooltip> where only the external tooltip is rendered and the internal one is wasted.

Wrapping a Tooltip around our Button in all instances also adds runtime cost that could otherwise be avoided entirely, and results in a smaller prop definition that only relates to the button. Developers get a more explicit API with better LSP experience while also giving us the bonus of a faster runtime experience.

@JonasBa JonasBa requested review from a team as code owners January 26, 2026 19:22
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 26, 2026
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

2 participants