fix(integrations): Treat IdentityNotValid as halt in metrics lifecycle #107024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
IdentityNotValidexceptions, which occur when OAuth refresh tokens become invalid (e.g., due to user revocation, password change, or expiration), were being recorded asfailuresin theIntegrationEventLifecycle. This led to a significant volume of unnecessary Sentry issues (over 500,000 events) and skewed integration SLO metrics, as these are expected behaviors in the OAuth lifecycle rather than system bugs.This change modifies the
IntegrationEventLifecycleto treatIdentityNotValidexceptions ashaltsinstead offailures. This aligns with howRestrictedIPAddressexceptions are handled, reducing noise in Sentry and improving the accuracy of our integration metrics.Changes Made:
IdentityNotValidfromsentry.auth.exceptions.IntegrationEventLifecycle.__exit__to check forIdentityNotValidand callrecord_halt()when encountered.IntegrationProxyEvent.capture()to returnIntegrationEventLifecycleto ensure that integration proxy events benefit from this updated exception handling.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.