truncate urls longer than 200 characters when adding them to the event from request interface #107070
+82
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds some truncation logic for long URLs which were previously omitted entirely
here's the resulting url tag after truncation:
"https://example.com/api/v1/very-long-path-segment-with-many-characters/very-long-path-segment-with-many-characters/very-long-path-segment-with-many-characters/very-long-path-segment-with-many-chara..."When generated from this script:
As part of response to this feedback here: https://x.com/tim_nolet/status/2008955053646991863
Note
Adds length guard for URL tags extracted from request interface.
UrlsPlugin.get_tag_valuesnow truncatesrequest.urltoMAX_TAG_VALUE_LENGTH, appending...when exceededWritten by Cursor Bugbot for commit 2ea2f37. This will update automatically on new commits. Configure here.