-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix(grouping): Prevent DiagnosticCoroutineContextException from determining issue title #107224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…mining issue title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| break | ||
|
|
||
| if main_exception_id: | ||
| if main_exception_id is not None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was already pre-existing I think: https://github.com/getsentry/sentry/pull/107224/changes#r2741145375
DiagnosticCoroutineContextExceptionis a Kotlin Coroutines debugging wrapperthat has no stacktrace and no meaningful message. When present in an exception
chain, it should not be used for the issue title. Instead, use the parent
exception which contains the actual error information.
See the linked issue for more examples and context.
Fixes getsentry/sentry-java#4410