ref(dashboards): rely on useQueries for referential stability of data #107340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@cursor review |
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
static/app/views/dashboards/widgetCard/hooks/useMobileAppSizeWidgetQuery.tsx
Outdated
Show resolved
Hide resolved
| firstError: results.find(q => q?.error)?.error as any, | ||
| queryData: results.map(q => q.data), | ||
| }; | ||
| } |
Contributor
There was a problem hiding this comment.
Duplicate combine functions with only type cast difference
Low Severity
Two nearly-identical functions combineQueryResultsWithFullError and combineQueryResultsWithRequestError have the same logic, differing only in the type cast on firstError (as any vs as RequestError | undefined). These could be consolidated into a single shared utility function that returns firstError: results.find(q => q?.error)?.error and let callers handle typing, reducing duplication and maintenance burden.
Additional Locations (1)
…ueries-reference-stability-in-order-instead-of
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in the dashboard api hooks we would store query result data in a ref, on rerender of the hook we would compare against that ref to see if data has changed. This works but there's a better way with react query.
Instead we use the combine property of
useQueriesto maintain ref stability which is less manual and less error prone