Skip to content

Conversation

@kcons
Copy link
Member

@kcons kcons commented Jan 31, 2026

Previously, each PerformanceDetector received the full settings dict for all detector types and extracted its own config in __init__. This meant every detector had visibility into other detectors' configuration, even though none actually used it.

Now the caller extracts the specific detector's settings before instantiation, so each detector only receives its own config dict, and we can be confident configs are independent.

@kcons kcons requested a review from a team January 31, 2026 01:13
@kcons kcons requested a review from a team as a code owner January 31, 2026 01:13
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 31, 2026
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

2 participants