ref(perf-detectors): Pass detector-specific settings to PerformanceDetector constructors #107387
+126
−99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, each PerformanceDetector received the full settings dict for all detector types and extracted its own config in
__init__. This meant every detector had visibility into other detectors' configuration, even though none actually used it.Now the caller extracts the specific detector's settings before instantiation, so each detector only receives its own config dict, and we can be confident configs are independent.