feat(auth): Auto-redirect authenticated users on auth pages via BroadcastChannel #107390
+53
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Scope: Frontend
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
…castChannel When users have multiple tabs open on auth pages and log in on one tab, other tabs still show the login form. This adds BroadcastChannel-based cross-tab communication to auto-redirect authenticated users. Changes: - Add `organizations:auth-broadcast-channel-redirect` feature flag - On login success (SPA flow), broadcast a 'login' message to other tabs - Auth pages listen for 'login' messages and reload (server redirects auth'd users) - Add visibility change fallback for SSO flows where BroadcastChannel may miss This complements the CSRF token sync fix for multi-tab scenarios.
JoshFerge
force-pushed
the
jferg/auth-broadcast-channel-redirect
branch
from
aa0caf4 to
af6f72d
Compare
JoshFerge
changed the base branch from
master
to
jferg/csrf-token-submit-intercept
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When users have multiple tabs open on auth pages and log in on one tab, other tabs still show the login form. This PR adds BroadcastChannel-based cross-tab communication to auto-redirect authenticated users.
organizations:auth-broadcast-channel-redirectfeature flag for gradual rolloutThis complements the CSRF token sync fix (#107389) for multi-tab scenarios.
Browser Support
BroadcastChannel is supported in Chrome 54+, Firefox 38+, Safari 15.4+, Edge 79+. Falls back gracefully (visibility change or CSRF sync) on older browsers.
Test Plan
/auth/login/{org}/Files Changed
src/sentry/features/temporary.py- Add feature flagsrc/sentry/web/frontend/auth_organization_login.py- Pass feature flag to template contextsrc/sentry/templates/sentry/organization-login.html- Expose config to JavaScriptsrc/sentry/templates/sentry/bases/auth.html- Add BroadcastChannel listener + visibility fallbackstatic/app/views/auth/loginForm.tsx- Broadcast login event on success