Skip to content

Conversation

@rohitvinnakota-codecov
Copy link
Contributor

@rohitvinnakota-codecov rohitvinnakota-codecov commented Aug 12, 2025

We were using the ORM directly to query objects but this is not multi region. Using the organization_service lets us leverage region blind searching.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 12, 2025
@codecov
Copy link

codecov bot commented Aug 12, 2025

❌ 30 Tests Failed:

Tests completed Failed Passed Skipped
26025 30 25995 557
View the top 3 failed test(s) by shortest run time
tests.sentry.seer.endpoints.test_seer_rpc.TestSeerRpc__InRegionMode::test_404
Stack Traces | 0.094s run time
#x1B[1m#x1B[.../seer/endpoints/test_seer_rpc.py#x1B[0m:55: in test_404
    path, data=data, HTTP_AUTHORIZATION=self.auth_header(path, data)
#x1B[1m#x1B[.../seer/endpoints/test_seer_rpc.py#x1B[0m:42: in auth_header
    signature = generate_request_signature(path, data.encode())
#x1B[1m#x1B[.../seer/endpoints/seer_rpc.py#x1B[0m:686: in generate_request_signature
    raise RpcAuthenticationSetupException("Cannot sign RPC requests without RPC_SHARED_SECRET")
#x1B[1m#x1B[31mE   sentry.hybridcloud.rpc.service.RpcAuthenticationSetupException: Cannot sign RPC requests without RPC_SHARED_SECRET#x1B[0m
tests.sentry.seer.endpoints.test_seer_rpc.TestSeerRpc__InControlMode::test_404
Stack Traces | 0.123s run time
#x1B[1m#x1B[.../seer/endpoints/test_seer_rpc.py#x1B[0m:55: in test_404
    path, data=data, HTTP_AUTHORIZATION=self.auth_header(path, data)
#x1B[1m#x1B[.../seer/endpoints/test_seer_rpc.py#x1B[0m:42: in auth_header
    signature = generate_request_signature(path, data.encode())
#x1B[1m#x1B[.../seer/endpoints/seer_rpc.py#x1B[0m:686: in generate_request_signature
    raise RpcAuthenticationSetupException("Cannot sign RPC requests without RPC_SHARED_SECRET")
#x1B[1m#x1B[31mE   sentry.hybridcloud.rpc.service.RpcAuthenticationSetupException: Cannot sign RPC requests without RPC_SHARED_SECRET#x1B[0m
tests.sentry.seer.endpoints.test_seer_rpc.TestSeerRpc__InControlMode::test_invalid_endpoint
Stack Traces | 0.145s run time
#x1B[1m#x1B[.../seer/endpoints/test_seer_rpc.py#x1B[0m:48: in test_invalid_endpoint
    response = self.client.post(path)
#x1B[1m#x1B[31m.venv/lib/python3.13.............../site-packages/rest_framework/test.py#x1B[0m:299: in post
    response = super().post(
#x1B[1m#x1B[31m.venv/lib/python3.13.............../site-packages/rest_framework/test.py#x1B[0m:213: in post
    return self.generic('POST', path, data, content_type, **extra)
#x1B[1m#x1B[31m.venv/lib/python3.13.............../site-packages/rest_framework/test.py#x1B[0m:237: in generic
    return super().generic(
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/test/client.py#x1B[0m:671: in generic
    return self.request(**r)
#x1B[1m#x1B[31m.venv/lib/python3.13.............../site-packages/rest_framework/test.py#x1B[0m:289: in request
    return super().request(**kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.............../site-packages/rest_framework/test.py#x1B[0m:241: in request
    request = super().request(**kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/test/client.py#x1B[0m:1087: in request
    self.check_exception(response)
#x1B[1m#x1B[31m.venv/lib/python3.13.../django/test/client.py#x1B[0m:802: in check_exception
    raise exc_value
#x1B[1m#x1B[31m.venv/lib/python3.13.../core/handlers/exception.py#x1B[0m:55: in inner
    response = get_response(request)
#x1B[1m#x1B[31m.venv/lib/python3.13.../core/handlers/base.py#x1B[0m:197: in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../views/decorators/csrf.py#x1B[0m:65: in _view_wrapper
    return view_func(request, *args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.13.../views/generic/base.py#x1B[0m:104: in view
    return self.dispatch(request, *args, **kwargs)
#x1B[1m#x1B[.../sentry/silo/base.py#x1B[0m:165: in override
    return handler(*args, **kwargs)
#x1B[1m#x1B[.../sentry/api/base.py#x1B[0m:695: in handle
    raise self.AvailabilityError(message)
#x1B[1m#x1B[31mE   sentry.silo.base.SiloLimit.AvailabilityError: Received POST request at '.../internal/seer-rpc/not_a_method/' to server in CONTROL mode. This endpoint is available only in: MONOLITH, REGION#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Member

@suejung-sentry suejung-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow nice find!

Copy link
Member

@suejung-sentry suejung-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing the original approval (sorry for being premature) since we're still all chatting on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components WIP

3 participants