-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Make themes more flexible #1004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
done. the section is formatted properly and tests pass |
It looks like it works while being much simple?! Can you add tests for shortcodes and an actual |
ping @southerntofu |
I didn't mean to close all the PRs by deleting the branch :( |
done. i also updated the docs
^ Would this change be welcome? |
I don't think it's common enough. And right now you can easily tests multiple themes and pick the one you prefer, which was the original intent. |
It looks good to me; anything else you want to add to the PR? |
next
branch?Fix for both #324 and #361. I open this PR to bring more attention so everyone can test and see if it makes them happy.
Following remarks here, i made sure this patch was fully backwards-compatible by copying the template's theme (inside tera) to "THEME/templates/index.html" in all cases, where THEME is the theme name.
In addition, I propose to copy all theme templates to "theme/templates/" where "theme" is a literal. This would allow site templates to extend the theme's template regardless of the theme name, so that you can swap themes seemlessly as long as they implement the same blocks in the base template. Would this be ok?
Waiting for feedback before i edit the docs