Skip to content

Conversation

southerntofu
Copy link
Contributor

  • Are you doing the PR on the next branch?
  • Have you created/updated the relevant documentation page(s)?
  • The change is fully backwards-compatible

Fix for both #324 and #361. I open this PR to bring more attention so everyone can test and see if it makes them happy.

Following remarks here, i made sure this patch was fully backwards-compatible by copying the template's theme (inside tera) to "THEME/templates/index.html" in all cases, where THEME is the theme name.

In addition, I propose to copy all theme templates to "theme/templates/" where "theme" is a literal. This would allow site templates to extend the theme's template regardless of the theme name, so that you can swap themes seemlessly as long as they implement the same blocks in the base template. Would this be ok?

Waiting for feedback before i edit the docs

@southerntofu
Copy link
Contributor Author

done. the section is formatted properly and tests pass

@Keats
Copy link
Collaborator

Keats commented Apr 29, 2020

It looks like it works while being much simple?! Can you add tests for shortcodes and an actual include?

@Keats
Copy link
Collaborator

Keats commented May 12, 2020

@Keats Keats closed this May 25, 2020
@Keats
Copy link
Collaborator

Keats commented May 25, 2020

I didn't mean to close all the PRs by deleting the branch :(

@Keats Keats reopened this May 25, 2020
@southerntofu
Copy link
Contributor Author

Can you add tests for shortcodes and an actual include?

done. i also updated the docs

In addition, I propose to copy all theme templates to "theme/templates/" where "theme" is a literal. This would allow site templates to extend the theme's template regardless of the theme name, so that you can swap themes seemlessly as long as they implement the same blocks in the base template. Would this be ok?

^ Would this change be welcome?

@Keats
Copy link
Collaborator

Keats commented Jun 9, 2020

This would allow site templates to extend the theme's template regardless of the theme name, so that you can swap themes seemlessly as long as they implement the same blocks in the base template.

I don't think it's common enough. And right now you can easily tests multiple themes and pick the one you prefer, which was the original intent.

@Keats
Copy link
Collaborator

Keats commented Jun 9, 2020

It looks good to me; anything else you want to add to the PR?

@Keats Keats merged commit e47decc into getzola:next Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants