Skip to content

fix: suppress highlight language warnings when highlight_code is false #2287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2023
Merged

fix: suppress highlight language warnings when highlight_code is false #2287

merged 1 commit into from
Aug 30, 2023

Conversation

welpo
Copy link
Contributor

@welpo welpo commented Aug 30, 2023

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Code changes

  • Are you doing the PR on the next branch?

This PR fixes #2280 by adding conditional logic to suppress warnings about unknown highlight languages when markdown.highlight_code is set to false in config.toml.
@welpo
fix: suppress highlight language warnings if highlight_code is false
15a4467 
The warning about unknown highlight languages was displayed even when
code highlighting was disabled via `markdown.highlight_code = false`.
This commit adds a condition to check this setting before issuing the
warning, effectively suppressing it when code highlighting is disabled.

Issue: #2280
Keats
Keats approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@Keats Keats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@Keats Keats merged commit 674c433 into getzola:next Aug 30, 2023
peterprototypes pushed a commit to peterprototypes/zola that referenced this pull request Sep 12, 2023
@welpo @peterprototypes
fix: suppress highlight language warnings if highlight_code is false (g…
73d2f7c 
…etzola#2287)

The warning about unknown highlight languages was displayed even when
code highlighting was disabled via `markdown.highlight_code = false`.
This commit adds a condition to check this setting before issuing the
warning, effectively suppressing it when code highlighting is disabled.

Issue: getzola#2280
technimad pushed a commit to technimad/zola that referenced this pull request Sep 30, 2023
@welpo
fix: suppress highlight language warnings if highlight_code is false (g…
e8a8c8a 
…etzola#2287)

The warning about unknown highlight languages was displayed even when
code highlighting was disabled via `markdown.highlight_code = false`.
This commit adds a condition to check this setting before issuing the
warning, effectively suppressing it when code highlighting is disabled.

Issue: getzola#2280
Keats pushed a commit that referenced this pull request Dec 18, 2023
@welpo @Keats
fix: suppress highlight language warnings if highlight_code is false (#…
670b882 
…2287)

The warning about unknown highlight languages was displayed even when
code highlighting was disabled via `markdown.highlight_code = false`.
This commit adds a condition to check this setting before issuing the
warning, effectively suppressing it when code highlighting is disabled.

Issue: #2280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@welpo @Keats