Skip to content

option to exit 0 instead of 1 when interaction disabled #1465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hickford wants to merge 1 commit into
base: main
Choose a base branch
from
Open

option to exit 0 instead of 1 when interaction disabled #1465

hickford wants to merge 1 commit into from

Conversation

@hickford
Copy link
Contributor

@hickford hickford commented Nov 4, 2023 •
edited
Loading

New option and environment variable GCM_SILENT_EXIT

Useful to run Git's credential helper test suite:

 GIT_TEST_CREDENTIAL_HELPER=manager GCM_CREDENTIAL_STORE=cache GCM_GUI_PROMPT=0 GCM_INTERACTIVE=never GCM_AUTODETECT_TIMEOUT=0 GCM_SILENT_EXIT=1  ./t0303-credential-external.sh

Fixes #1451

It remains to fix tests

not ok 11 - helper (manager) does not erase a password distinct from input
not ok 14 - helper (manager) can store empty username
not ok 18 - helper (manager) gets password_expiry_utc
not ok 19 - helper (manager) overwrites when password_expiry_utc changes
not ok 21 - helper (manager) gets oauth_refresh_token
@hickford hickford changed the title exit 0 instead of 1 when interaction disabled Nov 4, 2023
@hickford hickford marked this pull request as ready for review November 4, 2023 19:13
@hickford hickford marked this pull request as draft February 20, 2024 14:27
@hickford hickford marked this pull request as ready for review February 20, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@hickford