Skip to content

refactor: standardize use of renderWithAppContext and mocks#2392

Merged
setchy merged 19 commits intomainfrom
test/util-render-app-context
Nov 16, 2025
Merged

refactor: standardize use of renderWithAppContext and mocks#2392
setchy merged 19 commits intomainfrom
test/util-render-app-context

Conversation

@setchy
Copy link
Copy Markdown
Member

@setchy setchy commented Nov 16, 2025 •
edited
Loading

Significant refactor of tests to consistently

  • use renderWithAppContext (guarantees using primer theme and styles)
  • Naming of any mock objects or mock functions
  • Use defaults in test-utils where possible
  • clearer separation between mock files
@setchy
test: refactor render with app context
de87f0c 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
test: refactor render with app context
a724b43 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy setchy marked this pull request as draft November 16, 2025 20:25
@github-actions github-actions bot added the refactor Refactoring of existing feature label Nov 16, 2025
@setchy
test: refactor render with app context
c41e965 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
test: refactor render with app context
7db05ba 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
test: refactor render with app context
e471b08 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
test: refactor render with app context
9b25f8d 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
test: refactor render with app context
e701b7f 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
test: refactor render with app context
7be9d31 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
test: refactor render with app context
4bc9976 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
test: refactor render with app context
2b4b1a5 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
test: refactor render with app context
f6b610e 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy setchy changed the title refactor: tests to use custom renderWithAppContext Nov 16, 2025
@setchy
test: refactor render with app context
376e138 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
test: refactor render with app context
63e4073 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
Merge branch 'main' into test/util-render-app-context
a0b1a4b
@setchy setchy marked this pull request as ready for review November 16, 2025 22:03
@setchy
test: refactor render with app context
d92a7de 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
Merge branch 'test/util-render-app-context' of https://github.com/git…
6681146 
…ify-app/gitify into test/util-render-app-context
@setchy
test: refactor render with app context
d8a31f0 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
test: refactor render with app context
04cfba4 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
test: refactor render with app context
4e48d0a 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 16, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud
@setchy setchy merged commit 36d4be8 into main Nov 16, 2025
14 checks passed
@setchy setchy deleted the test/util-render-app-context branch November 16, 2025 22:28
@github-actions github-actions bot added this to the Release 6.14.0 milestone Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Refactoring of existing feature

1 participant

@setchy