Skip to content

fix: deduplicate HTTP methods in 405 Allow header #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nathannewyen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: deduplicate HTTP methods in 405 Allow header #1040

nathannewyen wants to merge 1 commit into from
+50 −0

Conversation

@nathannewyen
Copy link

@nathannewyen nathannewyen commented Dec 19, 2025 •
edited
Loading

Summary

  • Fixes duplicate HTTP methods appearing in the Allow header of 405 responses
  • When multiple overlapping wildcard routes match a path, each matching node was adding its methods to the Allow header, causing duplicates like Allow: POST POST POST POST
  • This fix uses a map to track seen methods and only adds each unique method once

Reproduction

As described in the issue, when routes overlap due to wildcards:

r.Post("/article/1-2-3", handler)
r.Post("/article/{a}", handler)
r.Post("/article/{b}-{c}", handler)
r.Post("/article/{b}-{c}-{d}", handler)

A GET request to /article/1-2-3 previously returned:

Allow: POST POST POST POST

Now correctly returns:

Allow: POST

Test plan

  • Added TestMethodNotAllowedDuplicateMethods test case
  • All existing tests pass

Fixes #996
@nathannewyen
fix: deduplicate HTTP methods in 405 Allow header
d95a851 
When multiple overlapping wildcard routes match the same path, the Allow
header in 405 responses was containing duplicate HTTP methods (e.g.,
"POST POST POST POST" instead of just "POST").

This fix uses a map to track seen methods and only adds each method once
to the Allow header.

Fixes go-chi#996
@nathannewyen nathannewyen force-pushed the fix-duplicate-allow-header branch from 9001d00 to d95a851 Compare December 19, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@nathannewyen