Remove common wsutil.Reader allocations #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
 * `ws.ReadHeader` allocates a 12 byte temporary buffer to read the header into. Since `io.ReadFull` is used, it escapes to the heap. * `wsutil.NewCipherReader` is used for many calls. Since the `NextFrame` shouldn't have concurrent calls, both of these should be possible to have internally. I am forced to copy "readHeader" from `ws`, since there is not way to eliminate the alloc otherwise as far as I can tell.
cristaloleg
approved these changes
Oct 30, 2023
Collaborator
|
Thanks! I will finish #171 tomorrow and will release a new version. |
klauspost
added a commit
to klauspost/minio
that referenced
this pull request
Nov 1, 2023
Removes some minor allocations and cleans up benchmarks as well as adds typed roundtrip benchmarks. Websocket library updated to include gobwas/ws#189
1 task
klauspost
added a commit
to klauspost/minio
that referenced
this pull request
Nov 1, 2023
Removes some minor allocations and cleans up benchmarks as well as adds typed roundtrip benchmarks. Websocket library updated to include gobwas/ws#189
harshavardhana
pushed a commit
to minio/minio
that referenced
this pull request
Nov 1, 2023
Removes some minor allocations and cleans up benchmarks as well as adds typed roundtrip benchmarks. Websocket library updated to include gobwas/ws#189
Collaborator
|
Sorry for the delay, released as v1.3.1 https://github.com/gobwas/ws/releases/tag/v1.3.1 |
klauspost
added a commit
to klauspost/minio
that referenced
this pull request
Nov 16, 2023
Removes some minor allocations and cleans up benchmarks as well as adds typed roundtrip benchmarks. Websocket library updated to include gobwas/ws#189
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ws.ReadHeaderallocates a 12 byte temporary buffer to read the header into. Sinceio.ReadFullis used, it escapes to the heap.wsutil.NewCipherReaderis allocated on each call to NextFrame.Since the
NextFrameshouldn't have concurrent calls, both of these should be possible to have internally.I am forced to copy "readHeader" from
ws, since there is not way to eliminate the alloc otherwise as far as I can tell.