refactor: Remove deprecated --all-files flag#11228
Conversation
Removes the deprecated `--all-files` / `-a` command-line flag and its corresponding `fullContext` logic throughout the codebase. This flag was previously used to include all files in the current directory as context. This functionality is now handled more explicitly by using `@` mentions (e.g., `@**/*`) within the prompt, providing users with more granular control. This change removes the flag from: - CLI argument parsing - All related configuration interfaces and implementations - Associated logic in the environment context builder - All mentions in the documentation Fixes #7361
Summary of ChangesHello @allenhutchison, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undertakes a significant refactoring effort to remove the deprecated Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively removes the deprecated --all-files flag and its associated fullContext logic from the entire codebase. The changes are comprehensive, covering CLI argument parsing, configuration interfaces, business logic, tests, and documentation. The removal is clean and thorough. I've found one issue in the documentation where a markdown table has been broken during the changes, which I've provided a suggestion to fix.
|
Size Change: -1.55 kB (-0.01%) Total Size: 17.8 MB
ℹ️ View Unchanged
|
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
abhipatel12
left a comment
abhipatel12
left a comment
There was a problem hiding this comment.
LGTM
Small nit is that in a few places we seem to be deleting a line but replacing it with a newline instead.
| - **`--all-files`** (**`-a`**): | ||
| - If set, recursively includes all files within the current directory as | ||
| context for the prompt. | ||
|
|
There was a problem hiding this comment.
nit: looks like we don't really add new lines for these flags in this section
| - **`--all-files`** (**`-a`**): | ||
| - If set, recursively includes all files within the current directory as | ||
| context for the prompt. | ||
|
|
There was a problem hiding this comment.
same nit: we may not need a newline here
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
## Major Changes ### Gemini CLI Integration (google-gemini/gemini-cli#11228) - Migrate from wrapper scripts to native Gemini CLI v0.11.0-nightly - Remove `-p` flag requirement for prompt strings - Deprecate `gemini-wrapper` and `qwen-wrapper` scripts - Update all commands and workflows to use direct CLI syntax ### Command Syntax Updates - **Before**: `gemini -p "CONTEXT: @**/* prompt"` - **After**: `gemini "CONTEXT: @**/* prompt"` - Apply to all 70+ command files and workflow templates - Maintain backward compatibility for Qwen fallback ### File Pattern Migration - Replace `@{CLAUDE.md}` with `@CLAUDE.md` - Replace `@{**/*}` with `@**/*` - Update all file references to use direct @ notation - Remove legacy brace syntax across all documentation ### Documentation Improvements - Reorganize `intelligent-tools-strategy.md` structure - Add Quick Start section with decision matrix - Enhance `--include-directories` best practices - Add comprehensive command templates and examples - Improve navigation with clearer section hierarchy ### Files Modified (75+ files) - Commands: All CLI commands updated (cli/, workflow/, task/, memory/) - Workflows: Core strategy files and templates - Agents: CLI execution agent and doc generator - Templates: Planning roles and tech stack guides ## Breaking Changes - Gemini CLI v0.11.0-nightly or later required - Old wrapper scripts no longer supported - Legacy `@{pattern}` syntax deprecated ## Migration Guide Users should: 1. Update Gemini CLI to v0.11.0-nightly or later 2. Remove `-p` flag from existing commands 3. Update file patterns from `@{pattern}` to `@pattern` 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
2 participants
Removes the deprecated
--all-files/-acommand-line flag and its correspondingfullContextlogic throughout the codebase.This flag was previously used to include all files in the current directory as context. This functionality is now handled more explicitly by using
@mentions (e.g.,@**/*) within the prompt, providing users with more granular control.This change removes the flag from:
Fixes #7361