feat: custom loading phrase when interactive shell requires input#12535
feat: custom loading phrase when interactive shell requires input#12535jackwotherspoon merged 14 commits intomainfrom
Conversation
Summary of ChangesHello @jackwotherspoon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a user experience issue where the CLI's loading indicator would continue to spin with general witty phrases even when an interactive shell was paused, awaiting user input. The change introduces a clear, dedicated loading phrase that appears after a short delay, informing the user that the interactive shell requires their attention. This significantly improves clarity and reduces user confusion by providing a more accurate status of the application. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Size Change: +3.59 kB (+0.02%) Total Size: 21.1 MB
ℹ️ View Unchanged
|
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
|
/gemini review |
![gemini-code-assist[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively addresses the confusing user experience when an interactive shell is awaiting input. The solution to display a clear loading phrase is well-implemented by tracking the last output time and using a timer to show the hint. The changes are logically sound and the addition of comprehensive tests is commendable. I have one suggestion to improve the maintainability of the useReactToolScheduler hook.
jackwotherspoon
force-pushed
the
interactive-shell-message
branch
from
4c8a10c to
687095e
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a helpful user experience improvement by displaying a custom loading phrase when an interactive shell is awaiting input. This prevents confusion when the shell is waiting for the user but the loading spinner is still active. The implementation is well-structured, introducing a new useInactivityTimer hook and correctly plumbing the necessary state through the component tree. The changes are logical and include relevant test updates.
I have one piece of feedback regarding a bug in the implementation of the inactivity timer for the focus hint, which could prevent the hint from showing up in certain scenarios.
…shell requires input (google-gemini#12535)
|
/patch preview |
|
✅ Patch workflow(s) dispatched successfully! 📋 Details:
🔗 Track Progress: |
|
🚀 Patch PR Created! 📋 Patch Details:
📝 Next Steps:
🔗 Track Progress: |
|
🚀 Patch Release Started! 📋 Release Details:
⏳ Status: The patch release is now running. You'll receive another update when it completes. 🔗 Track Progress: |
|
✅ Patch Release Complete! 📦 Release Details:
🎉 Status: Your patch has been successfully released and published to npm! 📝 What's Available:
🔗 Links: |
3 participants
Summary
Interactive shell hint
(ctrl+f to focus)is displayed when interactive shell is requiring input... however loading phrases keep spinning... making it seem like Gemini is still thinking or doing work.Example:
⠏ Mining for more Dilithium crystals... (esc to cancel, 12s)Details
This experience is confusing to users as they may not notice the interactive shell is requiring their input.
int.shell.message.mp4
Instead, displaying a very clear loading phrase that interactive shell is awaiting input provides a better DX.
Related Issues
Fixes #11765
How to Validate
Enable shell mode using
!and run an interactive command likenvim.After 5s of no output being displayed, both the hint and new loading phrase should appear.
Pre-Merge Checklist