feat(skills): add pr-creator skill and enable skills#16232
feat(skills): add pr-creator skill and enable skills#16232NTaylorMullen merged 2 commits intomainfrom
Conversation
Summary of ChangesHello @NTaylorMullen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates a new Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
- Added 'pr-creator' skill to guide PR creation according to repository standards. - Updated .gitignore to track .gemini/skills/ and .gemini/settings.json. - Created .gemini/settings.json to enable experimental skills for this project. - This ensures all contributors have access to the skill and the necessary configuration.
|
Size Change: -2 B (0%) Total Size: 22.3 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new setting ui.showHomeDirectoryWarning to control whether a warning is displayed when running the Gemini CLI in the user's home directory. The changes include adding the setting to the schema and documentation, and implementing the logic to check this setting before displaying the warning. While the changes for the home directory warning seem mostly correct, a critical type error was found in packages/cli/src/utils/userStartupWarnings.ts where an interface was changed but not all its implementations were updated, which will break compilation. Additionally, there is a significant discrepancy between the pull request's title and description, which focus on adding a pr-creator skill, and the actual code changes provided for review. This should be rectified for clarity.
283d53c to
a40796a
Compare
| !.gemini/config.yaml | ||
| !.gemini/commands/ | ||
| !.gemini/skills/ | ||
| !.gemini/settings.json |
There was a problem hiding this comment.
do we want to start including the settings.json?
There was a problem hiding this comment.
Without it you wont get skills by default. I figured it could be a way to share settings across the group. Add shared slash commands maybe a few other deets. Do you have specific settings that you personally disable in the repo?
| @@ -0,0 +1,5 @@ | |||
| { | |||
There was a problem hiding this comment.
Do we actually want to add this settings.json?
Summary
This PR introduces a new skill,
pr-creator, to standardize pull request creation and enables the skills feature for the project configuration.Details
.gemini/skills/pr-creator/SKILL.md, which instructs agents to locate and follow the repository's PR template..gitignoreto allow tracking of.gemini/skills/and.gemini/settings.json..gemini/settings.jsonwith"experimental": { "skills": true }to enable skills for anyone working in this repo.Related Issues
N/A
How to Validate
.gemini/skills/pr-creator/SKILL.mdexists and contains the correct instructions..gitignoreincludes the new exceptions..gemini/settings.jsonenables skills.Pre-Merge Checklist