-
Notifications
You must be signed in to change notification settings - Fork 10.9k
add borken link for testing #17986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add borken link for testing #17986
Conversation
Summary of ChangesHello @chrstnb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a deliberate change to a documentation link, making it point to a non-existent file. The explicit purpose, as stated in the title, is to facilitate testing, likely for validating documentation link checkers or error handling processes within the system. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a broken link into the documentation, seemingly for testing purposes. While I understand the need for testing, merging broken links into user-facing documentation can negatively impact users and should be avoided. I recommend finding an alternative way to conduct this test that doesn't involve committing broken links to the main branch. I've also included a suggestion to fix the link, which appeared to be incorrect even before this change.
docs/cli/skills.md
Outdated
|
|
||
| To create your own skills, see the | ||
| [Create Agent Skills](./guides/creating-skills.md) guide. | ||
| [Create Agent Skills](./guides/creating-skills-some-broken-link.md) guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change introduces a broken link. The pull request title indicates this is for testing, but merging broken links into user-facing documentation is not a good practice as it can confuse users. It would be better to handle such tests in a way that doesn't impact the main documentation, for instance, through a dedicated test suite or a temporary branch.
Furthermore, the original link also appears to be incorrect. Based on the file structure, the correct link should be ./creating-skills.md.
| [Create Agent Skills](./guides/creating-skills-some-broken-link.md) guide. | |
| [Create Agent Skills](./creating-skills.md) guide. |
|
Size Change: -2 B (0%) Total Size: 23.6 MB ℹ️ View Unchanged
|
Summary
Details
Related Issues
How to Validate
Pre-Merge Checklist