fix(ui): prevent content leak in MaxSizedBox bottom overflow

[jerop]

When using overflowDirection="bottom", content was bleeding through after the "... last N lines hidden ..." indicator:

... last 18 lines hidden ...rtant

This was caused by the inner overflow Box not having a constrained height. This change adds maxHeight constraint to inner overflow Box when overflowing.

Fixes #17990

[gemini-code-assist]

Summary of Changes

Hello @jerop, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a visual bug in the MaxSizedBox UI component where content would incorrectly appear below the overflow indicator when the overflowDirection was set to "bottom". The core of the fix involves dynamically applying a maxHeight property to the internal Box element, ensuring that content is properly clipped and the overflow indicator is displayed without any visual artifacts. A new test case has been introduced to validate this behavior, preventing regressions.

Highlights

• Content Leak Fix: Resolved an issue in MaxSizedBox where content would bleed through the "last N lines hidden" indicator when overflowDirection was set to "bottom".
• Height Constraint: Implemented a maxHeight constraint on the inner overflow Box component to prevent content leakage when overflowing.
• New Test Case: Added a dedicated test to MaxSizedBox.test.tsx to verify that content no longer leaks past the bottom overflow indicator.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively resolves a content leak issue in the MaxSizedBox component when overflowDirection is set to "bottom". The fix is concise and correctly applies a maxHeight constraint to the inner Box to prevent content from overflowing and appearing after the truncation indicator. The addition of a targeted test case that specifically checks for this content leak is excellent, ensuring the bug is resolved and preventing future regressions. The changes are well-implemented and improve the robustness of the UI component.

[github-actions]

Size Change: +192 B (0%)

Total Size: 23.6 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	23.6 MB	+192 B (0%)
./bundle/sandbox-macos-permissive-closed.sb	1.03 kB	0 B
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-closed.sb	3.29 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B

_{compressed-size-action}