-
Notifications
You must be signed in to change notification settings - Fork 10.9k
feat(core): add setting to disable loop detection #18008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @SandyTao520, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new configuration option to control the automatic loop detection mechanism within the system. This enhancement provides users with the flexibility to bypass the loop detection service, particularly in cases where the current system might misinterpret intended repetitive actions as infinite loops, thereby improving the user experience for specific workflows. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Build failed: Build process failed (no specific link errors found). Check logs for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new setting, model.disableLoopDetection, to give users the ability to turn off the automatic loop detection mechanism. The changes are well-implemented across the configuration, core logic, and documentation. The new setting is disabled by default for safety, and the implementation in LoopDetectionService is straightforward and correct. The inclusion of unit tests to verify the new behavior is also appreciated. Overall, this is a solid contribution that adds a useful feature for advanced users who might encounter false positives with the loop detection system.
|
Size Change: +639 B (0%) Total Size: 23.6 MB ℹ️ View Unchanged
|
1876a84 to
fb0fe4f
Compare
|
Build failed: Build process failed (no specific link errors found). Check logs for details. |
TLDR
This PR adds a new setting
model.disableLoopDetectionto allow users to disable the automatic detection and prevention of infinite loops. This is useful for scenarios where productive repetitive behavior is incorrectly flagged as a loop.Dive Deeper
The
LoopDetectionServicecurrently monitors both tool call repetitions and content streaming patterns. While effective, it can sometimes produce false positives. By adding this setting, users can opt-out of this behavior globally via theirsettings.jsonor the/settingscommand.Changes include:
configuration.mdandsettings.md.Reviewer Test Plan
/settingsand navigate to the Model section.false.settings.json.LoopDetectionServicebypasses its checks.Testing Matrix
Linked issues / bugs
#18007