feat(ui): make accept edits & yolo mode match shell mode styles#8200
feat(ui): make accept edits & yolo mode match shell mode styles#8200miguelsolorio merged 17 commits intomainfrom
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @miguelsolorio, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the user interface by extending the distinct visual styling currently applied to "shell mode" to "accept edits" and "yolo mode." The goal is to provide consistent and clear visual cues to users about the current operational mode, improving usability and reducing ambiguity.
Highlights
- Consistent UI Styling: Extends the visual styling pattern used for shell mode to "accept edits" and "yolo mode" for improved consistency and user experience.
- "Accept Edits" Visual Cue: Applies a success status (green) styling to the UI when in "accept edits" mode, providing clear feedback.
- "Yolo Mode" Visual Cue: Applies an error status (red) styling with a "*" prefix to the UI when in "yolo mode," indicating a distinct operational state.
- New
approvalModeProp: Introduces anapprovalModeprop to theInputPromptcomponent to control the application of these new styling modes.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request extends the styling from shell mode to 'accept edits' and 'yolo' modes. The changes are well-implemented, but there's an opportunity to refactor some duplicated logic in InputPrompt.tsx. I've left a few comments with suggestions to calculate the status color once and reuse it, which will improve the code's maintainability and readability.
|
Size Change: +754 B (+0.01%) Total Size: 13.2 MB ℹ️ View Unchanged
|
….com/google-gemini/gemini-cli into miguelsolorio/input-prompt-highlight
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
# Conflicts: # packages/cli/src/ui/components/InputPrompt.tsx
jacob314
left a comment
There was a problem hiding this comment.
Approved once these minor comments are addressed.
….com/google-gemini/gemini-cli into miguelsolorio/input-prompt-highlight
| <Text color={statusColor ?? theme.text.accent}> | ||
| <Text | ||
| color={statusColor ?? theme.text.accent} | ||
| aria-label={statusText || undefined} |
There was a problem hiding this comment.
@chrstnb added an aria label here, let me know if this looks correct to you.
… shell mode styles (google-gemini#8200)
|
Hello @miguelsolorio! I apologise you for tagging you, but I would like to know if I can customise the banner even if I want to show it. For example, I wish to change the name of Gemini to my name or another name in Gemini CLI’s settings in JSON. |

TLDR
When a user enters shell mode, we display a nice visual cue that they are in this special mode. This PR extends this styling to accept edits & yolo mode.
Dive Deeper
Extends the pattern we use for shell mode (see screenshot above). For "accept edits" we'll use the success status and for "yolo mode" we'll use the error status w/ a
*.Note: the shell/accept/yolo modes will eventually be left-aligned after #8041 is fixed
Reviewer Test Plan
Testing Matrix
Linked issues / bugs