weight_test: Use FLAGS_repeat for second_nested_product_tester iters#39
Merged
copybara-service[bot] merged 1 commit intomainfrom Apr 1, 2026
Merged
weight_test: Use FLAGS_repeat for second_nested_product_tester iters#39copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
copybara/892755674
branch
from
059fb5a to
86112f8
Compare
In the 1.5.0 release, many test iterations were bumped from 1 or 5 to FLAGS_repeat, but this one was not: 7f8e2c1#diff-9729ce4571791269b73144630db32552861e5968dfb8806c89a9db44475baadbL236 Timings essentially unchanged: Before this commit: //openfst/test:weight_test PASSED in 27.2s Stats over 20 runs: max = 27.2s, min = 26.7s, avg = 26.9s, dev = 0.1s With this commit: //openfst/test:weight_test PASSED in 26.2s Stats over 20 runs: max = 26.2s, min = 26.0s, avg = 26.2s, dev = 0.0s PiperOrigin-RevId: 893078396
copybara-service
bot
force-pushed
the
copybara/892755674
branch
from
86112f8 to
7376ddb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
weight_test: Use FLAGS_repeat for second_nested_product_tester iters
In the 1.5.0 release, many test iterations were bumped from 1 or 5 to
FLAGS_repeat, but this one was not:
7f8e2c1#diff-9729ce4571791269b73144630db32552861e5968dfb8806c89a9db44475baadbL236
Timings essentially unchanged:
Before this commit:
//openfst/test:weight_test PASSED in 27.2s
Stats over 20 runs: max = 27.2s, min = 26.7s, avg = 26.9s, dev = 0.1s
With this commit:
//openfst/test:weight_test PASSED in 26.2s
Stats over 20 runs: max = 26.2s, min = 26.0s, avg = 26.2s, dev = 0.0s