-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Betania Patmos GuideLine: Version 11.002; ttfautohint (v1.8.4.16-eb64) added #10152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…) added Taken from the upstream repo https://github.com/huertatipografica/betania-patmos at commit huertatipografica/betania-patmos@08c83ac.
FontSpector reportfontspector version: 1.5.2 Check results[4] ofl/betaniapatmosguideline/article/ARTICLE.en_us.html🔥 FAIL Does DESCRIPTION file contain a upstream Git repo URL? (googlefonts/description/git_url)
🔥 FAIL DESCRIPTION.en_us.html must have more than 200 bytes. (googlefonts/description/min_length)
🔥 FAIL Is this a proper HTML snippet? (googlefonts/description/valid_html)
|
| Glyph present in the font | Missing case-swapping counterpart |
|---|---|
| U+1E84: LATIN CAPITAL LETTER W WITH DIAERESIS | U+1E85: LATIN SMALL LETTER W WITH DIAERESIS |
| U+0102: LATIN CAPITAL LETTER A WITH BREVE | U+0103: LATIN SMALL LETTER A WITH BREVE |
| U+00D4: LATIN CAPITAL LETTER O WITH CIRCUMFLEX | U+00F4: LATIN SMALL LETTER O WITH CIRCUMFLEX |
| U+00C5: LATIN CAPITAL LETTER A WITH RING ABOVE | U+00E5: LATIN SMALL LETTER A WITH RING ABOVE |
| U+0132: LATIN CAPITAL LIGATURE IJ | U+0133: LATIN SMALL LIGATURE IJ |
| U+0100: LATIN CAPITAL LETTER A WITH MACRON | U+0101: LATIN SMALL LETTER A WITH MACRON |
| U+0174: LATIN CAPITAL LETTER W WITH CIRCUMFLEX | U+0175: LATIN SMALL LETTER W WITH CIRCUMFLEX |
| U+00DD: LATIN CAPITAL LETTER Y WITH ACUTE | U+00FD: LATIN SMALL LETTER Y WITH ACUTE |
| U+1E82: LATIN CAPITAL LETTER W WITH ACUTE | U+1E83: LATIN SMALL LETTER W WITH ACUTE |
| U+1E80: LATIN CAPITAL LETTER W WITH GRAVE | U+1E81: LATIN SMALL LETTER W WITH GRAVE |
| U+00C2: LATIN CAPITAL LETTER A WITH CIRCUMFLEX | U+00E2: LATIN SMALL LETTER A WITH CIRCUMFLEX |
| U+0178: LATIN CAPITAL LETTER Y WITH DIAERESIS | U+00FF: LATIN SMALL LETTER Y WITH DIAERESIS |
| U+00DB: LATIN CAPITAL LETTER U WITH CIRCUMFLEX | U+00FB: LATIN SMALL LETTER U WITH CIRCUMFLEX |
| U+1EF2: LATIN CAPITAL LETTER Y WITH GRAVE | U+1EF3: LATIN SMALL LETTER Y WITH GRAVE |
| U+0176: LATIN CAPITAL LETTER Y WITH CIRCUMFLEX | U+0177: LATIN SMALL LETTER Y WITH CIRCUMFLEX |
| U+00CE: LATIN CAPITAL LETTER I WITH CIRCUMFLEX | U+00EE: LATIN SMALL LETTER I WITH CIRCUMFLEX |
| U+00CA: LATIN CAPITAL LETTER E WITH CIRCUMFLEX | U+00EA: LATIN SMALL LETTER E WITH CIRCUMFLEX |
🔥 FAIL Whitespace glyphs have ink? (whitespace_ink)
- 🔥 FAIL The following glyphs have ink; they should be replaced by an empty glyph:
- space [code: has-ink]
🔥 FAIL Check family name for GF Guide compliance. (googlefonts/name/family_name_compliance)
- 🔥 FAIL "Betania Patmos GuideLine" is a CamelCased name. To solve this, simply use spaces instead in the font name. [code: camelcase]
⚠️ WARN Check if each glyph has the recommended amount of contours. (contour_count)
-
⚠️ WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are
inferred from the typical amounts of contours observed in a
large collection of reference font families. The divergences
listed below may simply indicate a significantly different
design on some of your glyphs. On the other hand, some of these
may flag actual bugs in the font such as glyphs mapped to an
incorrect codepoint. Please consider reviewing the design and
codepoint assignment of these to make sure they are correct.The following glyphs do not have the recommended number of contours:
- C (U+0043): found 4, expected one of: {2, 5, 1}
- I (U+0049): found 4, expected one of: {1, 3, 2}
- Itilde (U+0128): found 4, expected one of: {3, 6, 2}
- J (U+004A): found 4, expected one of: {2, 3, 1}
- S (U+0053): found 4, expected one of: {2, 1, 5}
- U (U+0055): found 4, expected one of: {1, 2, 5}
- Uacute (U+00DA): found 4, expected one of: {3, 2, 6}
- Ugrave (U+00D9): found 4, expected one of: {2, 3, 6}
- Utilde (U+0168): found 4, expected one of: {3, 6, 2}
... and 152 others [code: contour-count]
⚠️ WARN Check math signs have the same width. (math_signs_width)
⚠️ WARN The most common width is 710 among a set of 16 math glyphs.
The following math glyphs have a different width, though:
width=646: approxequal
width=638: uni2238
width=653: lessequal
width=636: uni2237
width=501: multiply
width=618: notequal
width=621: less, greater
width=671: uni2239
width=687: logicalnot [code: width-outliers]
⚠️ WARN Combined length of family and style must not exceed 32 characters. (name/family_and_style_max_length)
⚠️ WARN Name ID 6 'PostScript Name' exceeds 27 characters (3 characters too long). This has been found to cause problems with PostScript printers, especially on Mac platforms. [code: nameid6-too-long]
⚠️ WARN Check font contains no unreachable glyphs (unreachable_glyphs)
⚠️ WARN The following glyphs could not be reached by codepoint or substitution rules:
- b.init
- eth.init
- e.init
- eacute.init
- edieresis.init
- egrave.init
- uni1EBD.init
- f.init
- h.init
... and 36 others [code: unreachable-glyphs]
⚠️ WARN Do any segments have colinear vectors? (outline_colinear_vectors)
⚠️ WARN The following glyphs have colinear vectors:
- one.dnom: Line { p0: (206.0, 367.0), p1: (207.0, 367.0) } -> Line { p0: (207.0, 367.0), p1: (208.0, 367.0) }
- three.dnom: Line { p0: (101.0, 170.0), p1: (101.0, 171.0) } -> Line { p0: (101.0, 171.0), p1: (101.0, 172.0) }
- seven.dnom: Line { p0: (343.0, 338.0), p1: (343.0, 336.0) } -> Line { p0: (343.0, 336.0), p1: (343.0, 335.0) }
- one.numr: Line { p0: (206.0, 767.0), p1: (207.0, 767.0) } -> Line { p0: (207.0, 767.0), p1: (208.0, 767.0) }
- three.numr: Line { p0: (101.0, 570.0), p1: (101.0, 571.0) } -> Line { p0: (101.0, 571.0), p1: (101.0, 572.0) }
- seven.numr: Line { p0: (343.0, 738.0), p1: (343.0, 736.0) } -> Line { p0: (343.0, 736.0), p1: (343.0, 735.0) }
- uni2081 (U+2081): Line { p0: (143.0, 367.0), p1: (144.0, 367.0) } -> Line { p0: (144.0, 367.0), p1: (145.0, 367.0) }
- uni2083 (U+2083): Line { p0: (37.0, 170.0), p1: (37.0, 171.0) } -> Line { p0: (37.0, 171.0), p1: (37.0, 172.0) }
- uni2087 (U+2087): Line { p0: (278.0, 338.0), p1: (278.0, 336.0) } -> Line { p0: (278.0, 336.0), p1: (278.0, 335.0) }
... and 3 others [code: found-colinear-vectors]
⚠️ WARN Check there are no overlapping path segments (overlapping_path_segments)
⚠️ WARN The following glyphs have overlapping path segments:
- oslash.fina: Line(Line { p0: (0.0, 773.0), p1: (0.0, 780.0) }) has the same coordinates as a previous segment.
- oslash.fina: Line(Line { p0: (0.0, 417.0), p1: (0.0, 424.0) }) has the same coordinates as a previous segment.
- oslash.fina: Line(Line { p0: (0.0, -7.0), p1: (0.0, 11.0) }) has the same coordinates as a previous segment.
- oslash.fina: Line(Line { p0: (0.0, -370.0), p1: (0.0, -363.0) }) has the same coordinates as a previous segment.
- t.fina: Line(Line { p0: (418.0, 780.0), p1: (418.0, 773.0) }) has the same coordinates as a previous segment.
- t.fina: Line(Line { p0: (418.0, 424.0), p1: (418.0, 417.0) }) has the same coordinates as a previous segment.
- t.fina: Line(Line { p0: (418.0, 11.0), p1: (418.0, -7.0) }) has the same coordinates as a previous segment.
- t.fina: Line(Line { p0: (418.0, -363.0), p1: (418.0, -370.0) }) has the same coordinates as a previous segment.
- t.isol: Line(Line { p0: (418.0, 780.0), p1: (418.0, 773.0) }) has the same coordinates as a previous segment.
... and 19 others [code: overlapping-path-segments]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table. (googlefonts/meta/script_lang_tags)
⚠️ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
ℹ️ INFO Checking OS/2 fsSelection value. (opentype/xavgcharwidth)
- ℹ️ INFO OS/2 xAvgCharWidth is 567 but it should be 566 which corresponds to the average of the widths of all glyphs in the font. These are similar values, which may be a symptom of the slightly different calculation of the xAvgCharWidth value in font editors. There's further discussion on this at com.google.fonts/test/034: xAvgCharWidth bakery vs glyphs vs font val fonttools/fontbakery#1622 [code: xAvgCharWidth-close]
ℹ️ INFO Show hinting filesize impact. (hinting_impact)
- ℹ️ INFO Hinting filesize impact:
| BetaniaPatmosGuideLine-Regular.ttf | |
|---|---|
| Dehinted Size | 84192 |
| Hinted Size | 121504 |
| Increase | 37312 |
| Change | 44.3 % |
ℹ️ INFO Font contains all required tables? (required_tables)
-
ℹ️ INFO This font contains the following optional tables:
cvt
fpgm
loca
prep
GPOS
GSUB
gasp [code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |
| - Use smoothing along multiple axes with ClearType® | |
|---|---|
| [code: ranges] |
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
- ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 11.002; ttfautohint (v1.8.4.16-eb64) [code: version-not-detected]
Summary
| 🔥 FAIL | ℹ️ INFO | ✅ PASS | ⏩ SKIP | |
|---|---|---|---|---|
| 20 | 11 | 7 | 117 | 59 |
| 10% | 5% | 3% | 57% | 29% |
FontSpector reportfontspector version: 1.5.2 Check results[1] ofl/betaniapatmosguideline/article/ARTICLE.en_us.htmlℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL? (googlefonts/description/git_url)
[16] ofl/betaniapatmosguideline/BetaniaPatmosGuideLine-Regular.ttf🔥 FAIL Check base characters have non-zero advance width. (base_has_width)
🔥 FAIL Ensure the font supports case swapping for all its glyphs. (case_mapping)
🔥 FAIL Whitespace glyphs have ink? (whitespace_ink)
🔥 FAIL Check family name for GF Guide compliance. (googlefonts/name/family_name_compliance)
|
| BetaniaPatmosGuideLine-Regular.ttf | |
|---|---|
| Dehinted Size | 84192 |
| Hinted Size | 121504 |
| Increase | 37312 |
| Change | 44.3 % |
ℹ️ INFO Font contains all required tables? (required_tables)
-
ℹ️ INFO This font contains the following optional tables:
cvt
fpgm
loca
prep
GPOS
GSUB
gasp [code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |
| - Use smoothing along multiple axes with ClearType® | |
|---|---|
| [code: ranges] |
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
- ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 11.002; ttfautohint (v1.8.4.16-eb64) [code: version-not-detected]
[6] ofl/betaniapatmosguideline
🔥 FAIL Checking OS/2 usWinAscent & usWinDescent (family/win_ascent_and_descent)
-
🔥 FAIL OS/2.usWinAscent value should be equal or greater than 1170, but got 1072 instead. [code: ascent]
-
🔥 FAIL OS/2.usWinDescent value should be equal or greater than 588, but got 380 instead. [code: descent]
🔥 FAIL Check METADATA.pb parses correctly (googlefonts/metadata/consistent_with_fonts)
- 🔥 FAIL METADATA.pb family name field "Betania Patmos Guide Line" does not match correct family name "Betania Patmos GuideLine". [code: familyname-mismatch]
🔥 FAIL Tofu should not be shown in sample texts. (googlefonts/tofu)
- 🔥 FAIL We detected support for the Gheg Albanian language because the font contained all the base exemplars for the language, but the font is missing the following codepoints needed to render the specimen 16 sample text (This suggests there's something wrong with the sample text):
- â (U+00E2)
- ô (U+00F4)
- ê (U+00EA) [code: bad-sample-text]
- 🔥 FAIL The font has the following codepoints needed to render the specimen 16 sample text for language Yanomamö, but although the font contained all the codepoints for the sample text, tofu will still be produced because the codepoints do not appear in any of the subsets latin-ext, latin:
- ẽ (U+1EBD) [code: missing-subsetted]
- 🔥 FAIL We detected support for the Kabuverdianu language because the font contained all the base exemplars for the language, but the font is missing the following codepoints needed to render the poster sm sample text (This suggests there's something wrong with the sample text):
- â (U+00E2) [code: bad-sample-text]
- 🔥 FAIL We detected support for the Kabuverdianu language because the font contained all the base exemplars for the language, but the font is missing the following codepoints needed to render the specimen 16 sample text (This suggests there's something wrong with the sample text):
- ô (U+00F4)
- ê (U+00EA) [code: bad-sample-text]
- 🔥 FAIL We detected support for the Luxembourgish language because the font contained all the base exemplars for the language, but the font is missing the following codepoints needed to render the specimen 16 sample text (This suggests there's something wrong with the sample text):
- ê (U+00EA) [code: bad-sample-text]
- 🔥 FAIL We detected support for the Umbundu language because the font contained all the base exemplars for the language, but the font is missing the following codepoints needed to render the specimen 21 sample text (This suggests there's something wrong with the sample text):
- ê (U+00EA) [code: bad-sample-text]
- 🔥 FAIL We detected support for the Yapese language because the font contained all the base exemplars for the language, but the font is missing the following codepoints needed to render the specimen 16 sample text (This suggests there's something wrong with the sample text):
- ʼ (U+02BC) [code: bad-sample-text]
- 🔥 FAIL We detected support for the Yucateco language because the font contained all the base exemplars for the language, but the font is missing the following codepoints needed to render the specimen 16 sample text (This suggests there's something wrong with the sample text):
- ʼ (U+02BC) [code: bad-sample-text]
⚠️ WARN METADATA.pb subsets are correct? (googlefonts/metadata/subsets_correct)
⚠️ WARN Please remove 'latin-ext' from METADATA.pb since less than 20% of its glyphs are supported by this font file. [code: unsupported-subset]
⚠️ WARN Check for codepoints not covered by METADATA subsets. (googlefonts/metadata/unreachable_subsetting)
⚠️ WARN ofl/betaniapatmosguideline/BetaniaPatmosGuideLine-Regular.ttf: The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.
- U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
- U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
- U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
- U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: cherokee, math, tifinagh, coptic
- U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
- U+0307 COMBINING DOT ABOVE: try adding one of: old-permic, canadian-aboriginal, duployan, coptic, hebrew, syriac, tifinagh, math, tai-le, todhri, malayalam
- U+030A COMBINING RING ABOVE: try adding one of: duployan, syriac
- U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
- U+030C COMBINING CARON: try adding one of: tai-le, cherokee
... and 76 others
Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu [code: unreachable-subsetting]
ℹ️ INFO Check axis ordering on the STAT table. (googlefonts/STAT/axis_order)
- ℹ️ INFO All of the fonts lack a STAT table. [code: summary]
[1] ofl/betaniapatmosguideline/METADATA.pb
🔥 FAIL Check METADATA.pb parses correctly (googlefonts/metadata/validate)
-
🔥 FAIL METADATA.pb classifications field contains invalid value 'SYMBOLS'. Valid values are: Display, Handwriting, Monospace, Symbols [code: invalid-classification]
-
ℹ️ INFO Please consider adding a family.minisite_url entry. [code: lacks-minisite-url]
Summary
| 🔥 FAIL | ℹ️ INFO | ✅ PASS | ⏩ SKIP | |
|---|---|---|---|---|
| 16 | 9 | 8 | 122 | 59 |
| 8% | 4% | 4% | 60% | 29% |
Taken from the upstream repo https://github.com/huertatipografica/betania-patmos at commit huertatipografica/betania-patmos@08c83ac.
PR Checklist:
PR
QA
Specifics
primary_scriptdefinition in the METADATA.pb file for all projects that have a primary non-Latin based language support targetsubsetsdefinitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsetschinese-hongkong,chinese-simplified,chinese-traditional,korean,japanese.Release
minisite_urldefinition in the METADATA.pb file for commissioned projectstagsare added for NEW FONTS