Adding Bpmf Zihi Kai Std v1.610 #10173
Draft
+124
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
FontSpector reportfontspector version: 1.5.2 Checks with FATAL resultsThese must be addressed first. [1] ofl/bpmfzihikaistd/BpmfZihiKaiStd-Regular.ttf💥 ERROR Familyname must be unique according to namecheck.fontdata.com (fontdata_namecheck)
All other checks[2] ofl/bpmfzihikaistd/METADATA.pb
|
| Baseline | Computed | BASE table |
|---|---|---|
| Horizontal icfb | -58 | -64 |
| Horizontal icft | 802 | 840 |
| Horizontal ideo | -140 | -124 |
| Horizontal idtp | 883 | 900 |
| Horizontal romn | 0 | 0 |
| Vertical icfb | 77 | 60 |
| Vertical icft | 1460 | 1476 |
| Vertical ideo | 0 | 0 |
| Vertical idtp | 1536 | 1536 |
| Vertical romn | 140 | 120 |
🔥 FAIL Check font names are correct (googlefonts/font_names)
- 🔥 FAIL Font names are incorrect:
| Name | Current | Expected |
|---|---|---|
| Family Name | Bpmf Zihi KaiStd | Bpmf Zihi KaiStd |
| Subfamily Name | Regular | Regular |
| Full Name | Bpmf Zihi KaiStd Regular | Bpmf Zihi KaiStd Regular |
| Postscript Name | BpmfZihiKaiStd-Regular | BpmfZihiKaiStd-Regular |
| Typographic Family Name | Bpmf Zihi KaiStd | ㄅ字嗨注音標楷 |
| Typographic Subfamily Name | Regular | Regular |
⚠️ WARN Checking OS/2 fsSelection value. (opentype/xavgcharwidth)
⚠️ WARN OS/2 xAvgCharWidth is 1463 but it should be 1238 which corresponds to the average of the widths of all glyphs in the font. This may indicate a problem with the font editor or the font compiler. [code: xAvgCharWidth-wrong]
⚠️ WARN Does the font contain chws and vchw features? (cjk_chws_feature)
-
⚠️ WARN chws feature not found in font. Use chws_tool (https://github.com/googlefonts/chws_tool) to add it. [code: missing-chws-feature] -
⚠️ WARN vchw feature not found in font. Use chws_tool (https://github.com/googlefonts/chws_tool) to add it. [code: missing-vchw-feature]
⚠️ WARN Check if each glyph has the recommended amount of contours. (contour_count)
-
⚠️ WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are
inferred from the typical amounts of contours observed in a
large collection of reference font families. The divergences
listed below may simply indicate a significantly different
design on some of your glyphs. On the other hand, some of these
may flag actual bugs in the font such as glyphs mapped to an
incorrect codepoint. Please consider reviewing the design and
codepoint assignment of these to make sure they are correct.The following glyphs do not have the recommended number of contours:
- z_an4 (U+F00B): found 3, expected one of: {2, 1}
- z_ang2 (U+F00D): found 2, expected one of: {3, 1}
- z_ao4 (U+F013): found 2, expected one of: {1, 3}
- z_bao2 (U+F025): found 3, expected one of: {2, 14, 11}
- z_bei4 (U+F02B): found 3, expected one of: {1, 2}
- z_fen4 (U+F131): found 3, expected one of: {1}
- z_fen5 (U+F132): found 3, expected one of: {6, 1}
- z_feng1 (U+F133): found 2, expected one of: {1}
- z_feng2 (U+F134): found 3, expected one of: {2}
... and 200 others [code: contour-count]
⚠️ WARN Does GPOS table have kerning information? (gpos_kerning_info)
⚠️ WARN GPOS table lacks kerning information. [code: lacks-kern-info]
⚠️ WARN Check math signs have the same width. (math_signs_width)
⚠️ WARN The most common width is 1536 among a set of 16 math glyphs.
The following math glyphs have a different width, though:
width=576: uni003D, uni003E, uni003C, uni002B [code: width-outliers]
⚠️ WARN Ensure indic fonts have the Indian Rupee Sign glyph. (rupee)
⚠️ WARN Font is missing the Indian Rupee Sign glyph. Please add a glyph for Indian Rupee Sign (₹) at codepoint U+20B9. [code: missing-rupee]
⚠️ WARN Ensure Stylistic Sets have description. (stylisticset_description)
-
⚠️ WARN The stylistic set ss01 lacks a description string in the name table [code: missing-description] -
⚠️ WARN The stylistic set ss02 lacks a description string in the name table [code: missing-description] -
⚠️ WARN The stylistic set ss03 lacks a description string in the name table [code: missing-description] -
⚠️ WARN The stylistic set ss04 lacks a description string in the name table [code: missing-description] -
⚠️ WARN The stylistic set ss05 lacks a description string in the name table [code: missing-description] -
⚠️ WARN The stylistic set ss10 lacks a description string in the name table [code: missing-description]
⚠️ WARN Checking that the typoAscender exceeds the yMax of the /Agrave. (typoascender_exceeds_Agrave)
⚠️ WARN OS/2.sTypoAscender value should be greater than 949, but got 940 instead [code: typoAscender]
⚠️ WARN Glyph names are all valid? (valid_glyphnames)
⚠️ WARN Glyph 0x0020 is called uni0020; must be named 'space'. [code: not-recommended-0020]
⚠️ WARN Font has correct separator glyphs? (googlefonts/separator_glyphs)
⚠️ WARN The following separator glyphs are missing:
- U+2028
- U+2029 [code: missing-separator-glyphs]
⚠️ WARN Check the direction of the outermost contour in each glyph (outline_direction)
⚠️ WARN The following glyphs have a counter-clockwise outer contour:
- uni3109 (U+3109) has a counter-clockwise outer contour
- uniF000 (U+F000) has a counter-clockwise outer contour
- uniF000.vert has a counter-clockwise outer contour
- emptyBox (U+2610) has a counter-clockwise outer contour [code: ccw-outer-contour]
⚠️ WARN Do outlines contain any jaggy segments? (outline_jaggy_segments)
⚠️ WARN The following glyphs have jaggy segments:
- uni03BE (U+03BE): Quad(QuadBez { p0: (163.0, 686.0), p1: (214.0, 732.0), p2: (294.0, 747.0) })/Line(Line { p0: (294.0, 747.0), p1: (47.0, 736.0) }) = 8.06970626319496
- uni308C (U+308C): Quad(QuadBez { p0: (377.0, 495.0), p1: (365.0, 481.0), p2: (345.0, 453.0) })/Quad(QuadBez { p0: (345.0, 453.0), p1: (541.0, 630.0), p2: (660.0, 630.0) }) = 12.378353632757205
- uni3109 (U+3109): Quad(QuadBez { p0: (294.0, 813.0), p1: (296.0, 813.0), p2: (297.0, 812.0) })/Line(Line { p0: (297.0, 812.0), p1: (296.0, 813.0) }) = 0.0000012074182697257333
- uni3118 (U+3118): Quad(QuadBez { p0: (658.0, 602.0), p1: (728.0, 609.0), p2: (727.0, 609.0) })/Quad(QuadBez { p0: (727.0, 609.0), p1: (742.0, 610.0), p2: (772.0, 617.0) }) = 3.8140748342903783
- zyh: Quad(QuadBez { p0: (207.0, 277.0), p1: (250.0, 283.0), p2: (246.0, 282.0) })/Quad(QuadBez { p0: (246.0, 282.0), p1: (269.0, 286.0), p2: (274.0, 286.0) }) = 4.170436524842054
- zyzh: Quad(QuadBez { p0: (70.0, 149.0), p1: (72.0, 129.0), p2: (72.0, 130.0) })/Quad(QuadBez { p0: (72.0, 130.0), p1: (73.0, 126.0), p2: (79.0, 126.0) }) = 14.036243467926484
- zys: Quad(QuadBez { p0: (103.0, 177.0), p1: (117.0, 204.0), p2: (125.0, 222.0) })/Quad(QuadBez { p0: (125.0, 222.0), p1: (124.0, 219.0), p2: (136.0, 249.0) }) = 5.527540151656126
- zye: Quad(QuadBez { p0: (119.5, 199.0), p1: (100.0, 197.0), p2: (91.0, 195.0) })/Quad(QuadBez { p0: (91.0, 195.0), p1: (96.0, 196.0), p2: (60.0, 188.0) }) = 1.2188752351310335
- z_ce4 (U+F064): Quad(QuadBez { p0: (-392.5, 229.0), p1: (-412.0, 227.0), p2: (-421.0, 225.0) })/Quad(QuadBez { p0: (-421.0, 225.0), p1: (-416.0, 226.0), p2: (-452.0, 218.0) }) = 1.2188752351310335
... and 3152 others [code: found-jaggy-segments]
⚠️ WARN Check there are no overlapping path segments (overlapping_path_segments)
⚠️ WARN The following glyphs have overlapping path segments:
- uni6EF1 (U+6EF1): Line(Line { p0: (900.0, -125.0), p1: (998.0, -124.0) }) has the same coordinates as a previous segment.
- uni6EF1.ss00: Line(Line { p0: (900.0, -125.0), p1: (998.0, -124.0) }) has the same coordinates as a previous segment.
- uni972C (U+972C): Line(Line { p0: (599.0, 298.0), p1: (578.0, 302.0) }) has the same coordinates as a previous segment.
- uni972C.ss00: Line(Line { p0: (599.0, 298.0), p1: (578.0, 302.0) }) has the same coordinates as a previous segment. [code: overlapping-path-segments]
⚠️ WARN Do outlines contain any semi-vertical or semi-horizontal lines? (outline_semi_vertical)
⚠️ WARN The following glyphs have semi-vertical/semi-horizontal lines:
- uni004D (U+004D): Line(Line { p0: (142.0, 48.0), p1: (143.0, 682.0) })
- uni004D (U+004D): Line(Line { p0: (738.0, 334.0), p1: (739.0, 635.0) })
- uni004E (U+004E): Line(Line { p0: (183.0, 609.0), p1: (184.0, 49.0) })
- uni004E (U+004E): Line(Line { p0: (137.0, 48.0), p1: (138.0, 672.0) })
- uni004E (U+004E): Line(Line { p0: (617.0, 150.0), p1: (616.0, 680.0) })
- uni004E (U+004E): Line(Line { p0: (662.0, 681.0), p1: (661.0, -8.0) })
- uni0055 (U+0055): Line(Line { p0: (611.0, 318.0), p1: (610.0, 680.0) })
- uni0055 (U+0055): Line(Line { p0: (657.0, 682.0), p1: (655.0, 290.0) })
- uni0065 (U+0065): Line(Line { p0: (489.0, 262.0), p1: (132.0, 263.0) })
... and 8000 others [code: found-semi-vertical]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table. (googlefonts/meta/script_lang_tags)
⚠️ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
ℹ️ INFO Font contains all required tables? (required_tables)
-
ℹ️ INFO This font contains the following optional tables:
loca
BASE
GSUB
gasp
vhea
vmtx [code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |
| - Use smoothing along multiple axes with ClearType® | |
|---|---|
| [code: ranges] |
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
- ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 1.610 [code: version-not-detected]
[2] ofl/bpmfzihikaistd/article/ARTICLE.en_us.html
⚠️ WARN DESCRIPTION.en_us.html should end in a linebreak. (googlefonts/description/eof_linebreak)
⚠️ WARN The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it. [code: missing-eof-linebreak]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL? (googlefonts/description/git_url)
- ℹ️ INFO Found a git repo URL: https://github.com/ButTaiwan/bpmfvs [code: url-found]
Summary
| 💥 ERROR | 🔥 FAIL | ℹ️ INFO | ✅ PASS | ⏩ SKIP | |
|---|---|---|---|---|---|
| 1 | 35 | 30 | 7 | 102 | 66 |
| 0% | 17% | 15% | 3% | 50% | 32% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Onboarding three Bopomofo fonts:
Bpmf Zihi Kai Std
New project. At present, these are being built in https://github.com/aaronbell/bpmfvs, but will be transitioned upstream to https://github.com/ButTaiwan/bpmfvs once the rest of the fonts' build systems are modernized.