pass user.language=en to jarsigner command argument#82
Merged
thanwah merged 1 commit intogoogle:masterfrom Feb 8, 2021
Merged
Conversation
Contributor
|
Thank you for creating this PR. I haven't been able to reproduce this issue myself (e.g. by switching to another language), but I also don't find that this causes any problems. So under the presumption that it fixes your issue, I'm working now on getting this merged (I have to merge it with my internal code repository before it will show up here). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Description
The "Build Android App Bundle" works fine until just before the signing phase, but the signing process never ends.
Reason
In my understanding, The Jarsigner class is supposed to invoke the jarsigner command and monitor the keyword "Enter Passphrase for keystore:" and then pass the keystore password.
However, in an environment other than English, for example, in a Japanese environment, the keyword output by the jarsiginer command is a different from above, so the Jarsigner class cannot detect it and cannot pass the password.
for example, in english environment
in japanese environment
$jarsigner -keystore {keystore} {app_bundle_path} {alias} キーストアのパスワードを入力してください:Fix
Change the output to be in English by passing the "-Duser.language=en" option to jarsigner.
in japanese environment with the option