Skip to content

fix: Add the ability to set UUID in AssignerSettings #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 19, 2022
Merged

fix: Add the ability to set UUID in AssignerSettings #1296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1830154
fix: Add the ability to set UUID in AssignerSettings
dpcollins-google Dec 19, 2022
92029f1
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Dec 19, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@ If you are using Maven, add this to your pom.xml file:
If you are using Gradle without BOM, add this to your dependencies:

```Groovy
implementation 'com.google.cloud:google-cloud-pubsublite:1.9.1'
implementation 'com.google.cloud:google-cloud-pubsublite:1.9.2'
```

If you are using SBT, add this to your dependencies:

```Scala
libraryDependencies += "com.google.cloud" % "google-cloud-pubsublite" % "1.9.1"
libraryDependencies += "com.google.cloud" % "google-cloud-pubsublite" % "1.9.2"
```

## Authentication
Expand Down
16 changes: 11 additions & 5 deletions ...-pubsublite/src/main/java/com/google/cloud/pubsublite/internal/wire/AssignerSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,11 @@ public abstract class AssignerSettings {

abstract PartitionAssignmentServiceClient serviceClient();

// Optional parameters.
abstract UUID uuid();

public static Builder newBuilder() {
return new AutoValue_AssignerSettings.Builder();
return new AutoValue_AssignerSettings.Builder().setUuid(UUID.randomUUID());
}

@AutoValue.Builder
Expand All @@ -48,15 +51,18 @@ public abstract static class Builder {

public abstract Builder setServiceClient(PartitionAssignmentServiceClient serviceClient);

// Optional parameters.
public abstract Builder setUuid(UUID uuid);

public abstract AssignerSettings build();
}

public Assigner instantiate() {
UUID uuid = UUID.randomUUID();
ByteBuffer uuidBuffer = ByteBuffer.allocate(16);
uuidBuffer.putLong(uuid.getMostSignificantBits());
uuidBuffer.putLong(uuid.getLeastSignificantBits());
logger.atInfo().log("Subscription %s using UUID %s for assignment.", subscriptionPath(), uuid);
uuidBuffer.putLong(uuid().getMostSignificantBits());
uuidBuffer.putLong(uuid().getLeastSignificantBits());
logger.atInfo().log(
"Subscription %s using UUID %s for assignment.", subscriptionPath(), uuid());

InitialPartitionAssignmentRequest initial =
InitialPartitionAssignmentRequest.newBuilder()
Expand Down