Skip to content

chore: replace SystemExecutors with MoreExecutors #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
import com.google.api.gax.rpc.OperationCallable;
import com.google.api.gax.rpc.PageContext;
import com.google.api.gax.rpc.UnaryCallable;
import com.google.cloud.pubsublite.internal.wire.SystemExecutors;
import com.google.cloud.pubsublite.proto.CreateReservationRequest;
import com.google.cloud.pubsublite.proto.CreateSubscriptionRequest;
import com.google.cloud.pubsublite.proto.CreateTopicRequest;
Expand Down Expand Up @@ -65,6 +64,7 @@
import com.google.cloud.pubsublite.proto.UpdateTopicRequest;
import com.google.cloud.pubsublite.v1.stub.AdminServiceStub;
import com.google.cloud.pubsublite.v1.stub.AdminServiceStubSettings;
import com.google.common.util.concurrent.MoreExecutors;
import com.google.longrunning.Operation;
import com.google.longrunning.OperationsClient;
import com.google.protobuf.Empty;
Expand Down Expand Up @@ -2292,7 +2292,7 @@ public ListTopicsPagedResponse apply(ListTopicsPage input) {
return new ListTopicsPagedResponse(input);
}
},
SystemExecutors.getFuturesExecutor());
MoreExecutors.directExecutor());
}

private ListTopicsPagedResponse(ListTopicsPage page) {
Expand Down Expand Up @@ -2372,7 +2372,7 @@ public ListTopicSubscriptionsPagedResponse apply(ListTopicSubscriptionsPage inpu
return new ListTopicSubscriptionsPagedResponse(input);
}
},
SystemExecutors.getFuturesExecutor());
MoreExecutors.directExecutor());
}

private ListTopicSubscriptionsPagedResponse(ListTopicSubscriptionsPage page) {
Expand Down Expand Up @@ -2457,7 +2457,7 @@ public ListSubscriptionsPagedResponse apply(ListSubscriptionsPage input) {
return new ListSubscriptionsPagedResponse(input);
}
},
SystemExecutors.getFuturesExecutor());
MoreExecutors.directExecutor());
}

private ListSubscriptionsPagedResponse(ListSubscriptionsPage page) {
Expand Down Expand Up @@ -2542,7 +2542,7 @@ public ListReservationsPagedResponse apply(ListReservationsPage input) {
return new ListReservationsPagedResponse(input);
}
},
SystemExecutors.getFuturesExecutor());
MoreExecutors.directExecutor());
}

private ListReservationsPagedResponse(ListReservationsPage page) {
Expand Down Expand Up @@ -2624,7 +2624,7 @@ public ListReservationTopicsPagedResponse apply(ListReservationTopicsPage input)
return new ListReservationTopicsPagedResponse(input);
}
},
SystemExecutors.getFuturesExecutor());
MoreExecutors.directExecutor());
}

private ListReservationTopicsPagedResponse(ListReservationTopicsPage page) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
import com.google.api.gax.rpc.BidiStreamingCallable;
import com.google.api.gax.rpc.PageContext;
import com.google.api.gax.rpc.UnaryCallable;
import com.google.cloud.pubsublite.internal.wire.SystemExecutors;
import com.google.cloud.pubsublite.proto.CommitCursorRequest;
import com.google.cloud.pubsublite.proto.CommitCursorResponse;
import com.google.cloud.pubsublite.proto.ListPartitionCursorsRequest;
Expand All @@ -38,6 +37,7 @@
import com.google.cloud.pubsublite.proto.SubscriptionName;
import com.google.cloud.pubsublite.v1.stub.CursorServiceStub;
import com.google.cloud.pubsublite.v1.stub.CursorServiceStubSettings;
import com.google.common.util.concurrent.MoreExecutors;
import java.io.IOException;
import java.util.List;
import java.util.concurrent.TimeUnit;
Expand Down Expand Up @@ -437,7 +437,7 @@ public ListPartitionCursorsPagedResponse apply(ListPartitionCursorsPage input) {
return new ListPartitionCursorsPagedResponse(input);
}
},
SystemExecutors.getFuturesExecutor());
MoreExecutors.directExecutor());
}

private ListPartitionCursorsPagedResponse(ListPartitionCursorsPage page) {
Expand Down
2 changes: 1 addition & 1 deletion synth.metadata
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"git": {
"name": ".",
"remote": "https://github.com/googleapis/java-pubsublite.git",
"sha": "5fe36cb035f255f7c5c984ef770724be977bd2e9"
"sha": "5bae5ec48e278100fc8aa2305ea581cba4d04ff0"
}
},
{
Expand Down