Skip to content

chore: remove deprecated registration of the span names for zpages #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 24, 2020
Merged

chore: remove deprecated registration of the span names for zpages #27

merged 3 commits into from
Jan 24, 2020

Conversation

mayurkale22
Copy link
Member

@mayurkale22 mayurkale22 commented Jan 10, 2020 •
edited
Loading

Fixes #21

The registerSpanNamesForCollection() method is deprecated since OpenCensus-0.18 release, the alternative is EndSpanOptions#getSampleToLocalSpanStore()

See: https://github.com/census-instrumentation/opencensus-java/blob/2a17c8482ffb04540ea4ac0a5f746ad8d536c996/api/src/main/java/io/opencensus/trace/export/SampledSpanStore.java#L102-L112
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 10, 2020
@mayurkale22
Copy link
Member Author

This is my first PR here, please guide me if I am missing anything.
@mayurkale22
Copy link
Member Author

/cc @bogdandrutu please review
@chingor13 chingor13 removed their request for review January 15, 2020 20:30
@mayurkale22
Copy link
Member Author

@skuruppu When do you expect this to land ?
@skuruppu
Copy link
Contributor

@skuruppu When do you expect this to land ?

I don't know why the build didn't trigger for it but I've triggered a manual build for this PR so hopefully it works.

You can see it at sponge/39f68490-b680-42e6-b059-1be161809bcb.
@skuruppu
Copy link
Contributor

@skuruppu When do you expect this to land ?

I don't know why the build didn't trigger for it but I've triggered a manual build for this PR so hopefully it works.

You can see it at sponge/39f68490-b680-42e6-b059-1be161809bcb.

Sorry @mayurkale22, I pushed a PR that fails the binary compatibility test and that seems to be blocking the remainder of the tests from running. I'm hoping to resolve the issue within the next day.
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 23, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 23, 2020
@olavloite
Copy link
Collaborator

This is my first PR here, please guide me if I am missing anything.

Hi @mayurkale22,

Welcome to the Java client :-)

A couple of tips:

  1. I assume that this PR is intended to fix issue TraceUtil.java:[75,12] registerSpanNamesForCollection(java.util.Collection<java.lang.String>) in io.opencensus.trace.export.SampledSpanStore has been deprecated #21. It is customary to include the text 'Fixes TraceUtil.java:[75,12] registerSpanNamesForCollection(java.util.Collection<java.lang.String>) in io.opencensus.trace.export.SampledSpanStore has been deprecated #21' in the PR description. The PR is then also automatically linked to the issue, so that anyone looking at the issue will also see that it is being worked on.
  2. If your build gets stuck or in other ways seems not to be responding, you can trigger a new build by adding the label 'kokoro:force-run' to the PR. The label will automatically be removed by the build bot when the build is started.
@mayurkale22
Copy link
Member Author

@skuruppu @olavloite build is passing now :)
@skuruppu skuruppu merged commit b619fed into googleapis:master Jan 24, 2020
@yoshi-automation yoshi-automation mentioned this pull request Jan 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
6 participants
@mayurkale22 @skuruppu @olavloite @bogdandrutu @googlebot @yoshi-kokoro