Skip to content

test: adds test for numeric as primary key #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 8, 2021
Merged

test: adds test for numeric as primary key #857

merged 4 commits into from
Jul 8, 2021

Conversation

thiagotnunes
Copy link
Contributor

Adds test for numeric as primary key.
@thiagotnunes thiagotnunes requested a review from a team as a code owner February 8, 2021 03:25
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 8, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Feb 8, 2021
@thiagotnunes thiagotnunes added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed api: spanner Issues related to the googleapis/java-spanner API. labels Feb 8, 2021
@codecov
Copy link

codecov bot commented Feb 8, 2021 •
edited
Loading

Codecov Report

Merging #857 (72a195a) into master (58cebd8) will increase coverage by 0.04%.
The diff coverage is 95.83%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #857      +/-   ##
============================================
+ Coverage     85.06%   85.10%   +0.04%     
- Complexity     2585     2589       +4     
============================================
  Files           143      143              
  Lines         14145    14154       +9     
  Branches       1369     1366       -3     
============================================
+ Hits          12032    12046      +14     
+ Misses         1541     1539       -2     
+ Partials        572      569       -3
Impacted Files Coverage Δ Complexity Δ
...spanner/admin/database/v1/DatabaseAdminClient.java 83.22% <ø> (ø) 100.00 <0.00> (ø)
...spanner/admin/instance/v1/InstanceAdminClient.java 79.14% <ø> (ø) 56.00 <0.00> (ø)
...ava/com/google/cloud/spanner/v1/SpannerClient.java 82.05% <ø> (ø) 63.00 <0.00> (ø)
...cloud/spanner/connection/SingleUseTransaction.java 91.35% <66.66%> (+2.40%) 32.00 <2.00> (ø)
...oogle/cloud/spanner/connection/ConnectionImpl.java 84.93% <100.00%> (+0.09%) 175.00 <0.00> (ø)
...m/google/cloud/spanner/connection/SpannerPool.java 87.89% <100.00%> (+1.00%) 33.00 <2.00> (+2.00)
...le/cloud/spanner/connection/StatementExecutor.java 80.76% <100.00%> (+1.60%) 9.00 <2.00> (+2.00)
...ud/spanner/SessionPoolAsyncTransactionManager.java 85.71% <0.00%> (-1.59%) 11.00% <0.00%> (-2.00%)
...a/com/google/cloud/spanner/SessionPoolOptions.java 69.53% <0.00%> (-0.79%) 18.00% <0.00%> (-1.00%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58cebd8...f57ff41. Read the comment docs.
olavloite
olavloite reviewed Feb 8, 2021
View reviewed changes
@thiagotnunes thiagotnunes removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 2, 2021
@thiagotnunes thiagotnunes requested a review from skuruppu March 2, 2021 23:35
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 6, 2021
@thiagotnunes thiagotnunes added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 13, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Apr 28, 2021
@olavloite
Copy link
Collaborator

@thiagotnunes Is there a specific reason that this has not yet been merged?
@thiagotnunes
Copy link
Contributor Author

@olavloite yes, this is currently not supported by the backend yet.
@thiagotnunes thiagotnunes merged commit a1c09d3 into googleapis:master Jul 8, 2021
@thiagotnunes thiagotnunes deleted the numeric-pk-test branch July 8, 2021 08:12
ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request Nov 10, 2022
@yoshi-automation
chore(all): auto-regenerate .pb.go files (googleapis#857)
042d03a 
This is an auto-generated regeneration of the .pb.go files by
cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will
update the corresponding PR to depend on the newer version of go-genproto, and
assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot
will not create any more regeneration PRs. If all regen PRs are closed,
gapicgen will create a new set of regeneration PRs once per night.

If you have been assigned to review this PR, please:

- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship. That will prompt
genbot to assign reviewers to the google-cloud-go PR.

Corresponding google-cloud-go PR: googleapis/google-cloud-go#6337

Changes:

feat(bigquery/migration): Add Presto dialect to bigquerymigration v2 client library
  PiperOrigin-RevId: 460797158
  Source-Link: googleapis/googleapis@46f2598

chore: regenerate API index

  Source-Link: googleapis/googleapis@52cae2e

feat: added support for BatchCreateTasks preview
  PiperOrigin-RevId: 460776984
  Source-Link: googleapis/googleapis@c501985

chore: regenerate API index

  Source-Link: googleapis/googleapis@d87a170

feat: publish cloud networksecurity v1
  PiperOrigin-RevId: 460770654
  Source-Link: googleapis/googleapis@e7edbb9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. cla: yes This human has signed the Contributor License Agreement.
4 participants
@thiagotnunes @olavloite @skuruppu @yoshi-kokoro