Skip to content

fix: don't override the global logging config #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 26, 2023
Merged

fix: don't override the global logging config #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4d91f28
fix: don't override the global logging config
tswast Oct 24, 2023
a7d7094
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Oct 24, 2023
93e1e18
Merge branch 'main' into tswast-logging
tswast Oct 26, 2023
50f78a3
Merge branch 'main' into tswast-logging
gcf-merge-on-green[bot] Oct 26, 2023
5e1ce8f
Merge branch 'main' into tswast-logging
gcf-merge-on-green[bot] Oct 26, 2023
4fa6bec
Merge branch 'main' into tswast-logging
gcf-merge-on-green[bot] Oct 26, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions bigframes/clients.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@
from google.cloud import bigquery_connection_v1, resourcemanager_v3
from google.iam.v1 import iam_policy_pb2, policy_pb2

logging.basicConfig(
level=logging.INFO, format="[%(levelname)s][%(asctime)s][%(name)s] %(message)s"
)
logger = logging.getLogger(__name__)


Expand Down
5 changes: 0 additions & 5 deletions bigframes/remote_function.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,6 @@
from bigframes import clients
import bigframes.constants as constants

# TODO(shobs): Change the min log level to INFO after the development stabilizes
# before June 2023
logging.basicConfig(
level=logging.INFO, format="[%(levelname)s][%(asctime)s][%(name)s] %(message)s"
)
logger = logging.getLogger(__name__)

# Protocol version 4 is available in python version 3.4 and above
Expand Down