Skip to content

fix: Fix issue with iterating on >10gb dataframes #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2024
Merged

fix: Fix issue with iterating on >10gb dataframes #949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50b3908
fix: Fix issue with iterating on >10gb dataframes
TrevorBergeron Sep 4, 2024
4e3b889
Merge branch 'main' into batches_fix
tswast Sep 4, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion bigframes/core/blocks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,9 @@ def to_pandas_batches(
see https://cloud.google.com/python/docs/reference/bigquery/latest/google.cloud.bigquery.job.QueryJob#google_cloud_bigquery_job_QueryJob_result"""
dtypes = dict(zip(self.index_columns, self.index.dtypes))
dtypes.update(zip(self.value_columns, self.dtypes))
_, query_job = self.session._execute(self.expr, ordered=True)
_, query_job = self.session._executor.execute(
self.expr, ordered=True, use_explicit_destination=True
)
results_iterator = query_job.result(
page_size=page_size, max_results=max_results
)
Expand Down
1 change: 1 addition & 0 deletions bigframes/session/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1324,6 +1324,7 @@ def _execute(
*,
ordered: bool = True,
col_id_overrides: Mapping[str, str] = {},
use_explicit_destination: bool = False,
) -> tuple[bigquery.table.RowIterator, bigquery.QueryJob]:
return self._executor.execute(
array_value,
Expand Down
8 changes: 8 additions & 0 deletions bigframes/session/executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ def execute(
*,
ordered: bool = True,
col_id_overrides: Mapping[str, str] = {},
use_explicit_destination: bool = False,
):
"""
Execute the ArrayValue, storing the result to a temporary session-owned table.
Expand All @@ -113,6 +114,13 @@ def execute(
array_value, ordered=ordered, col_id_overrides=col_id_overrides
)
job_config = bigquery.QueryJobConfig()
# Use explicit destination to avoid 10GB limit of temporary table
if use_explicit_destination:
schema = array_value.schema.to_bigquery()
destination_table = self.storage_manager.create_temp_table(
schema, cluster_cols=[]
)
job_config.destination = destination_table
# TODO(swast): plumb through the api_name of the user-facing api that
# caused this query.
return self._run_execute_query(
Expand Down