Skip to content

tests: unflake ud system test to only run in prod and hmac sample test #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Sep 27, 2024

  • Universe domain tests will run in kokoro presubmit and continuous builds only in prod. Secrets are not shared in preprod cbuild, so skipping test in preprod cbuild. Confirmed that tests pass in prod presubmit and continous

  • Unflake hmac sample test - handle cleanup where keys are already deleted

Fixes #1349 🦕

@cojenco cojenco requested review from a team as code owners September 27, 2024 18:06
@cojenco cojenco requested a review from leahecole September 27, 2024 18:06
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. labels Sep 27, 2024
@cojenco cojenco requested a review from andrewsg September 27, 2024 18:14
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 27, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 27, 2024
@cojenco cojenco merged commit bebd97a into googleapis:main Sep 27, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. size: xs Pull request size is extra small.
2 participants