Skip to content

fix: Skip duplicated label name filtering in some cases #4502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Skip duplicated label name filtering in some cases #4502

wants to merge 1 commit into from
+15 −14

Conversation

jake-kramer
Copy link
Contributor

No description provided.

@jake-kramer jake-kramer marked this pull request as ready for review October 10, 2025 14:30
@jake-kramer jake-kramer mentioned this pull request Oct 10, 2025
Merged
simonswine
simonswine approved these changes Oct 13, 2025
View reviewed changes
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM
pkg/querier/querier.go
level.Debug(q.logger).Log("msg", "filtering out label", "label_name", name)
continue
return response.Msg.Names, nil
} else {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Find it easier to read without the else branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@jake-kramer @simonswine