Use this for SchemaInternals types#3115
Open
joshkel wants to merge 1 commit into
Open
Conversation
Using `this` instead of `Schema` for methods that clone the input parameter is more precise - for example, calling `$_addRule` on a NumberSchema returns a NumberSchema. `$_setFlag` was typed as returning void, but it returns an object of the same type. See example code at https://joi.dev/api/18.x.x#extensions. Note that, as a type in TypeScript, "`this` refers dynamically to the type of the current class", so it can refer to a clone of the method's class as well as the class's own instance. See https://www.typescriptlang.org/docs/handbook/2/classes.html#this-types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
thisinstead ofSchemafor methods that clone the input parameter is more precise - for example, calling$_addRuleon a NumberSchema returns a NumberSchema.$_setFlagwas typed as returning void, but it returns an object of the same type. See example code at https://joi.dev/api/18.x.x#extensions.Note that, as a type in TypeScript, "
thisrefers dynamically to the type of the current class", so it can refer to a clone of the method's class as well as the class's own instance. Seehttps://www.typescriptlang.org/docs/handbook/2/classes.html#this-types