-
-
Notifications
You must be signed in to change notification settings - Fork 36.7k
Optimize attribute lookup in DSMR Reader #161994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Optimize attribute lookup in DSMR Reader #161994
Conversation
|
Hey there @sorted-bits, @Glodenox, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
| def message_received(message): | ||
| """Handle new MQTT messages.""" | ||
| if message.payload == "": | ||
| if not (payload := message.payload): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be wrong due to my somewhat limited knowledge of Python, but I think this will have the unwanted effect of marking zeros and False values as None.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a sharp observation! I didn't take the actual 0 in consideration. I can write a fix for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, then there's no risk indeed :)

Breaking change
Proposed change
Optimize attribute lookups, by introducing the walrus operator. Should save a few lookups.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: