Skip to content

Conversation

@bicycleboy
Copy link

Breaking change

Existing users must delete the " - platform: nsw_fuel_station" sensor configuration from configuration.yaml. Sensor names will remain the same for dashboards.

Proposed change

User changes:

  • Add support for Tasmania
  • Add dynamically updated "cheapest fuel nearby" sensors
  • Add configuration via UI including location selector
  • Add support for additional types of fuel

Code changes:

  • complete rewrite based on ludeeus blueprint
  • modern HA "compliant" config_flow.py, coordinator.py etc
  • bronze checklist reviewed and hopefully implemented
  • some shortcuts pending user feedback

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • [ x] New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR addresses the desire to update legacy integrations
  • Test coverage, ruff tests etc completed in standalone repo
  • associated API library (https://github.com/bicycleboy/nsw-fuel-api-client) also updated, pending PR, currently only on TestPyPi

Checklist

  • [ x] I understand the code I am submitting and can explain how it works.
  • [x ] The code change is tested and works locally.
  • [ x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x ] There is no commented out code in this PR.
  • [ x] I have followed the development checklist
  • [ x] I have followed the perfect PR recommendations
  • [x ] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [x ] Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ pending] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [pending ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bicycleboy

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot added cla-needed config-flow This integration migrates to the UI by adding a config flow has-tests integration: nsw_fuel_station new-feature labels Feb 1, 2026
@home-assistant home-assistant bot marked this pull request as draft February 1, 2026 06:23
@home-assistant
Copy link

home-assistant bot commented Feb 1, 2026

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link

home-assistant bot commented Feb 1, 2026

Hey there @nickw444, mind taking a look at this pull request as it has been labeled with an integration (nsw_fuel_station) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of nsw_fuel_station can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign nsw_fuel_station Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.
@bicycleboy bicycleboy changed the title Rewite legacy integration based on ludeeus blueprint, add UI config, new user features Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

1 participant