-
-
Notifications
You must be signed in to change notification settings - Fork 36.7k
Add number entity to Liebherr integration #162011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a number entity platform to the Liebherr integration to allow controlling temperature setpoints for fridge/freezer zones. The PR also claims to upgrade the integration from Bronze to Silver quality scale.
Changes:
- Added number platform with temperature setpoint control functionality
- Updated test infrastructure to support platform-specific testing
- Added translations for number entities
- Claimed upgrade to Silver quality scale (but missing implementation)
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| homeassistant/components/liebherr/init.py | Added Platform.NUMBER to PLATFORMS list |
| homeassistant/components/liebherr/number.py | New number platform implementation for temperature setpoint control |
| homeassistant/components/liebherr/strings.json | Added translations for number entities and exception messages |
| homeassistant/components/liebherr/quality_scale.yaml | Marked log-when-unavailable as done (incorrectly) |
| homeassistant/components/liebherr/manifest.json | Upgraded quality_scale from bronze to silver (prematurely) |
| tests/components/liebherr/conftest.py | Updated fixtures to support platform-specific testing, added target/min/max to MOCK_DEVICE_STATE |
| tests/components/liebherr/test_sensor.py | Updated to use platforms fixture parameter |
| tests/components/liebherr/test_number.py | New comprehensive test file for number platform |
| tests/components/liebherr/snapshots/test_number.ambr | Snapshot tests for number entities |
Proposed change
Added number entity for controlling setpoint temperature to Liebherr integration
Upgraded quality scale to silver as all silver tier items are done
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: