Skip to content

[tests] add test for torch.compile + group offloading #11670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 6, 2025
Merged

[tests] add test for torch.compile + group offloading #11670

merged 2 commits into from
Jun 6, 2025

Conversation

sayakpaul
Copy link
Member

@sayakpaul sayakpaul commented Jun 6, 2025 •
edited
Loading

What does this PR do?

Only makes sense to have one after #11605. To run:

RUN_SLOW=1 RUN_COMPILE=1 pytest tests/models/ -k "test_compile_with_group_offloading".

Cc: @stevhliu do you think we should document this thing in our torch.compile() documentation section?
@sayakpaul sayakpaul requested review from DN6 and a-r-r-o-w June 6, 2025 05:04
@sayakpaul sayakpaul added performance Anything related to performance improvements, profiling and benchmarking torch.compile labels Jun 6, 2025
@DN6
Copy link
Collaborator

DN6 commented Jun 6, 2025

Looks good. We wouldn't need this specific command since the current -k "compile" will pick up the test since compile is in the name.

RUN_SLOW=1 RUN_COMPILE=1 pytest tests/models/ -k "test_compile_with_group_offloading"
@sayakpaul sayakpaul merged commit 16c955c into main Jun 6, 2025
29 checks passed
@sayakpaul sayakpaul deleted the offload-compile-tests branch June 6, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Anything related to performance improvements, profiling and benchmarking torch.compile
2 participants
@sayakpaul @DN6