-
Notifications
You must be signed in to change notification settings - Fork 6.2k
[docs] quant_kwargs #11712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] quant_kwargs #11712
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Do we have to include an explicit point on how users can derive qaunt_kwargs
for a given backend?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm undecided as to what is best, to include each quantization backend here as @sayakpaul mentioned or to an index of them like you did, so I'll leave it to you.
Also I wanted to see the final docs but the doc builder failed.
I think it's probably best to refer the user to the specific API docs for each backend where they can find all the relevant arguments, and keep this one more high-level. Not sure why the doc-builder is failing though. bitsandbytes should already be installed in the CI test environment no? 🤔 |
Yeah indeed. I was asking for an explicit note that says just that. |
No actually. I opened #11728 for this. Let's see. |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
||
### Simple quantization | ||
### Basic quantization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in line 94 there's a link to 'simple quantization' so this will break it, change the other link then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw this too late I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, should be fixed in #12018!
Improves where you can find the
quant_kwargs
in thePipelineQuantizationConfig
docs