feat(settings): add UI defaults for audio/subtitle language and subtitle type - #881
Open
huynhsontung with Copilot wants to merge 2 commits into
Open
feat(settings): add UI defaults for audio/subtitle language and subtitle type#881huynhsontung with Copilot wants to merge 2 commits into
huynhsontung with Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/huynhsontung/Screenbox/sessions/f8f4a7a0-e468-41ef-9f9e-a8c3b3a4f0b7 Co-authored-by: huynhsontung <31434093+huynhsontung@users.noreply.github.com>
huynhsontung
force-pushed
the
copilot/feature-set-default-audio-subtitle-settings
branch
from
June 12, 2026 07:27
d6cf7fc to
5ee3a2c
Compare
huynhsontung
marked this pull request as ready for review
June 12, 2026 07:29
Collaborator
|
After a brief review, I wasn't particularly impressed. I wouldn't make the default audio or subtitle language that prominent (if at all). Each setting fits better as its own card within the Advanced expander. And about the subtitle behavior, I really dislike how it's implemented. It makes more sense as an enum, and the strings/options need a thorough rewrite. It's far too English and anime‑centric, and it would even fail one of the examples in #837. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users could only set preferred audio/subtitle languages through advanced VLC arguments or per-playback track selection. This change adds first-class Settings UI for these preferences and applies them in app playback logic (not LibVLC startup arguments).
Settings surface (Player section)
Any,Full subtitles,Signs / songs)en-USresource strings for labels/descriptions/options.Persisted settings model
ISettingsService/SettingsServicewith:PersistentAudioLanguagePersistentSubtitleTypePreferencePersistentSubtitleLanguagefor subtitle language selection from Settings.Playback selection logic (application-side)
Any: first language matchFull: prefer non-signs/song tracksSigns / songs: prefer signs/song/lyric/forced-labeled tracksExample (selection behavior)