Skip to content

feat: update typesense search index on rfc pub/update#10575

Merged
jennifer-richards merged 20 commits into
ietf-tools:mainfrom
jennifer-richards:typesense-noogies
Mar 23, 2026
Merged

feat: update typesense search index on rfc pub/update#10575
jennifer-richards merged 20 commits into
ietf-tools:mainfrom
jennifer-richards:typesense-noogies

Conversation

@jennifer-richards
Copy link
Copy Markdown
Member

@jennifer-richards jennifer-richards commented Mar 18, 2026

Does an upsert() with data intended to match what the initial JS index build tool generated. Has been tested against a local typesense instance, but have not done a systematic comparison at all.

Draft while I work on the tests. Ready to go, I think

Things to think about for this or later work: (edit: I think best to take this as a complete feature and leave these for future improvements)

  • The _sanitize_text() method in searchindex.py is based on the JS treatment of the content field. I don't completely understand the goals, but it would be good to review this for reasonableness.
  • We'll want to add a full rebuild action using typesense's bulk update API. That's not in this PR.
  • Datatracker should probably be in charge of the Typesense schema for this collection. That's also not in this PR. For now, it's using what's already set up.
@jennifer-richards jennifer-richards marked this pull request as ready for review March 19, 2026 10:15
NGPixel
NGPixel previously approved these changes Mar 19, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 20, 2026

Codecov Report

❌ Patch coverage is 97.84946% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.39%. Comparing base (76fd25a) to head (546e4c0).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
ietf/utils/searchindex.py 96.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10575      +/-   ##
==========================================
+ Coverage   88.36%   88.39%   +0.02%     
==========================================
  Files         327      328       +1     
  Lines       44092    44204     +112     
==========================================
+ Hits        38964    39073     +109     
- Misses       5128     5131       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@jennifer-richards jennifer-richards merged commit d39317b into ietf-tools:main Mar 23, 2026
10 checks passed
@jennifer-richards jennifer-richards deleted the typesense-noogies branch March 23, 2026 15:33
@evyncke
Copy link
Copy Markdown
Collaborator

evyncke commented Mar 24, 2026

Should requirements.txt be updated to include the "httpx" module ?

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 27, 2026
@jennifer-richards
Copy link
Copy Markdown
Member Author

Should requirements.txt be updated to include the "httpx" module ?

Yes, since we refer to it we should include it. I think it should be pulled in automatically as a dependency of the typesense package, though, so it shouldn't actually be required for this to work as intended.

@jennifer-richards
Copy link
Copy Markdown
Member Author

Should requirements.txt be updated to include the "httpx" module ?

#10678

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants