2 updates to functionality and 1 bug fix #14
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add ability to get debug info back rather than output to console mostly my mentions are executed by apache so I have no console. support @kylewm's relative path to webmention endpoint which explains why he wasn't getting any webmentions from me
Member
|
The library has been pretty significantly refactored since this PR was filed (1.5 years ago)... These days it does support relative endpoints, and it returns the POST response to sending a webmention, so you should be able to get the headers from Bridgy. If the other changes are still needed, unfortunately I think the only way to do it would be to make them again starting with the current codebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KyleWM is using a webmention endpoint as a relative url '/webmention' which obviously was not working. I added a bit to check if the endpoint is relative and correct it if so.
I added an ability to return the text from the debug messages by a call rather than only output to console.
I added the ability to get back any URLs returned by webmention clients. This is very useful for brid.gy integration as I get the syndication links it returns to me.